Criteo Bid Adapter: add eids to bid request sent to bidder #9949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
assigning @dgirardi as reviewer to best handle the discussion question. Fwiw, this is how Improve and Openx work afaik. |
|
You are correct that eids could be fed into |
|
#9951 to track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Ensure that eids from id modules are sent to bidder.
Other information
Question to the reviewer: wouldn't it be interesting to automatically feed ortb2.user.ext.eids with id modules ids rather than expecting the bidder to grab them from bid level userIdAsEids? (sorry if my question looks stupid and there's an obvious reason we should really not do this)