-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile and Makefile #1099
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,12 +16,16 @@ RUN apt-get update && \ | |
apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
ENV CGO_ENABLED 0 | ||
COPY ./ ./ | ||
RUN go mod vendor | ||
RUN go mod tidy | ||
ARG TEST="true" | ||
RUN if [ "$TEST" != "false" ]; then ./validate.sh ; fi | ||
RUN go build -mod=vendor . | ||
|
||
FROM ubuntu:18.04 AS release | ||
LABEL maintainer="[email protected]" | ||
WORKDIR /usr/local/bin/ | ||
COPY --from=build /app/prebid-server/ . | ||
COPY --from=build /app/prebid-server/prebid-server . | ||
COPY static static/ | ||
COPY stored_requests/data stored_requests/data | ||
RUN apt-get update && \ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,27 @@ | ||
# Makefile | ||
|
||
all: | ||
@echo "" | ||
@echo " deps: grab dependencies using go modules" | ||
@echo " test: test prebid-server (via validate.sh)" | ||
@echo " build: build prebid-server" | ||
@echo " image: build docker image" | ||
@echo "" | ||
all: deps test build | ||
|
||
.PHONY: install deps test build image | ||
.PHONY: deps test build image | ||
|
||
# deps will clean out the vendor directory and use go mod for a fresh install | ||
deps: | ||
rm -rf vendor | ||
GOPROXY="https://proxy.golang.org" go mod vendor -v && go mod tidy -v | ||
|
||
# test will ensure that all of our dependencies are available and run validate.sh | ||
test: deps | ||
# If there is no indentation, Make will treat it as a directive for itself; otherwise, it's regarded as a shell script. | ||
# https://stackoverflow.com/a/4483467 | ||
ifeq "$(adapter)" "" | ||
./validate.sh | ||
|
||
# TODO: when adapters are in their own packages we can enable adapter-specific testing by passing the "adapter" argument | ||
#ifeq ($(adapter),"all") | ||
# ./validate.sh | ||
#else | ||
# go test github.com/prebid/prebid-server/adapters/$(adapter) -bench=. | ||
#endif | ||
else | ||
go test github.com/prebid/prebid-server/adapters/$(adapter) -bench=. | ||
endif | ||
|
||
# build will ensure all of our tests pass and then build the go binary | ||
build: test | ||
go build -mod=vendor ./... | ||
|
||
# image will build a docker image | ||
image: build | ||
image: | ||
docker build -t prebid-server . |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
ARG
defining the environment variable"true"
? if it is going to be hardcoded, why not just runningvalidate.sh
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually the default value. I understand it can be a little confusing but the
ARG
value that you pass in the command line will override that. And the reason for thetrue
default value is we wanna always run the tests as part of building the image unless specified otherwise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. I already approved Mansi