Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile and Makefile #1099

Merged
merged 2 commits into from
Nov 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,16 @@ RUN apt-get update && \
apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
ENV CGO_ENABLED 0
COPY ./ ./
RUN go mod vendor
RUN go mod tidy
ARG TEST="true"
RUN if [ "$TEST" != "false" ]; then ./validate.sh ; fi
RUN go build -mod=vendor .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ARG defining the environment variable "true"? if it is going to be hardcoded, why not just running validate.sh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually the default value. I understand it can be a little confusing but the ARG value that you pass in the command line will override that. And the reason for the true default value is we wanna always run the tests as part of building the image unless specified otherwise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I already approved Mansi


FROM ubuntu:18.04 AS release
LABEL maintainer="[email protected]"
WORKDIR /usr/local/bin/
COPY --from=build /app/prebid-server/ .
COPY --from=build /app/prebid-server/prebid-server .
COPY static static/
COPY stored_requests/data stored_requests/data
RUN apt-get update && \
Expand Down
26 changes: 9 additions & 17 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,35 +1,27 @@
# Makefile

all:
@echo ""
@echo " deps: grab dependencies using go modules"
@echo " test: test prebid-server (via validate.sh)"
@echo " build: build prebid-server"
@echo " image: build docker image"
@echo ""
all: deps test build

.PHONY: install deps test build image
.PHONY: deps test build image

# deps will clean out the vendor directory and use go mod for a fresh install
deps:
rm -rf vendor
GOPROXY="https://proxy.golang.org" go mod vendor -v && go mod tidy -v

# test will ensure that all of our dependencies are available and run validate.sh
test: deps
# If there is no indentation, Make will treat it as a directive for itself; otherwise, it's regarded as a shell script.
# https://stackoverflow.com/a/4483467
ifeq "$(adapter)" ""
./validate.sh

# TODO: when adapters are in their own packages we can enable adapter-specific testing by passing the "adapter" argument
#ifeq ($(adapter),"all")
# ./validate.sh
#else
# go test github.com/prebid/prebid-server/adapters/$(adapter) -bench=.
#endif
else
go test github.com/prebid/prebid-server/adapters/$(adapter) -bench=.
endif

# build will ensure all of our tests pass and then build the go binary
build: test
go build -mod=vendor ./...

# image will build a docker image
image: build
image:
docker build -t prebid-server .