Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.14 Build Target #1314

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Add Go 1.14 Build Target #1314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ language: go
go:
- '1.12'
- '1.13'
- '1.14'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will build against the initial 1.14 release. Is this desired? Should it be 1.14.2 for what we'll use in the Docker image? .. or 1.14.x for the current minor release of 1.14?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using Go 1.14.2 in prebid-cache, it gets downloaded and installed as specified in prebid-caches Dockerfile. I think we could use 1.14.2 in prebid-server as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. How about we leave as 1.14 for now and then switch to 1.14.x to match the Docker image when it's updated in a future PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


go_import_path: github.com/prebid/prebid-server

Expand Down