-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: vscode remote container support #1481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a cool dev setup. I also think this won't be what everyone wants to work with. How do you feel about adding this primarily as markdown with sample json file contents along with instructions?
Can the sample files be in I don't mind this not being merged at all, as I wrote it's just a suggestion; but from my experience, spinning up the IDE with dependencies and the right extensions to get to trying out changes, would've been a decent bonus when I started. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is pretty cool and I think it's worth merging as long as it's opt-in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We (finally) got around to discussing this PR. We think it's great to offer guidance for devs who want to use this feature. Let's just leave the default vscode setup alone for now.
Why: The vscode Golang plugin enforces style, identifies errors and has a remote debugger. Developing in a container isolates the dev environment from the host machine.
What does this do
Add support for Visual Studio Code with In-Container Development.
Why
I've added a small VSCODE.md for orientation.
The rest are applicable to on-host vscode development too:
Here is a screenshot showing most of the features in a squeezed window.
One drawback that I noticed is that if the container is cpu-limited, and it usually is, the tests will need a timeout longer than 10min sometimes to avoid failures.