Bidder Uniqueness Gatekeeping Test #1506
Conversation
openrtb_ext/bidders_test.go
Outdated
| } | ||
|
|
||
| currentUniquenessThreshold := 6 | ||
| assert.Equal(t, currentUniquenessThreshold, maxUniqueForPrefixLength(bidders)) |
There was a problem hiding this comment.
This test looks good but I'm assuming we aren't anticipating the bidder names changing, is that correct? I think this test would fail if one of the smart* bidder names changed such that there is a difference in the first five characters of their names instead of the difference starting at the sixth character:
BidderSmartadserver BidderName = "smartadserver"
BidderSmartRTB BidderName = "smartrtb"
Perhaps this check should be a less than or equal to?
There was a problem hiding this comment.
I'm assuming we aren't anticipating the bidder names changing.
Correct. I'm sure it could happen, but the cost of doing so is high. Such a move would invalidate a lot of stored requests and publisher setup. Hence, appnexus is still appnexus even though the company is now part of Xandr.
Perhaps this check should be a less than or equal to?
Sure. That's a good point. This test is meant to sound alarm if the minimum characters needed for uniqueness increases.
No description provided.