Add Adot adapter #1599
Closed
Add Adot adapter #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Giudici-a thank you for submitting your adapter. Starting our next release on December 3rd, adapter source code will need to be written in a slightly different way. Pull request #1532 describes this changes. Therefore, before we merge your adapter:
|
|
Hi, @guscarreon, thank you for your response. I look at this and i will make the necessary changes. |
* First draft * Brian's reivew * Removed leftover comments Co-authored-by: Gus Carreon <[email protected]>
|
We also just published a new adapter doc today which will guide you through the changes. I'm still fixing some formatting issues, sorry about that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.