Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicorn: Revert limitation of JPY only ( add limitation of accountId ) #2277

Merged
merged 6 commits into from
Jun 23, 2022
Merged

Unicorn: Revert limitation of JPY only ( add limitation of accountId ) #2277

merged 6 commits into from
Jun 23, 2022

Commits on Jun 17, 2022

  1. revert JPY only logic, add validation of accountId

    @faithnh
    faithnh committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    c8e6d2f View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. fix test case

    @faithnh
    faithnh committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    6bb92fa View commit details
    Browse the repository at this point in the history

  2. remove checking accountId is zero and test case for accountId is zero… 

    …, and no accountId
    @faithnh
    faithnh committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    c7ca31e View commit details
    Browse the repository at this point in the history

  3. remove unusual print

    @faithnh
    faithnh committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    d87e7fc View commit details
    Browse the repository at this point in the history

  4. fix review

    @faithnh
    faithnh committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    4a72511 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. fix bug that accountId set zero in modifyImps when not have accountId… 

    … and add test case of no accountId
    @faithnh
    faithnh committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    4b0121f View commit details
    Browse the repository at this point in the history