New Adapter: InfyTV #2278
New Adapter: InfyTV #2278
Conversation
|
@infytvcode Looks like there's a test failure due to URL mismatch in one of your test cases. Can you please fix this when you have a chance? |
adapters/infytv/infytv.go
Outdated
| "github.com/prebid/prebid-server/openrtb_ext" | ||
| ) | ||
|
|
||
| type InfytvAdapter struct { |
There was a problem hiding this comment.
You can call this simply "Adapter", the "Infytv" identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be infytv.InfytvAdapter which looks a little redundant.
There was a problem hiding this comment.
@hhhjort Thanks for the suggestion. Will update it.
Fixing failing tests
|
Documentation Pull request prebid/prebid.github.io#3865 |
| } | ||
| } | ||
|
|
||
| var validParams = []string{ |
There was a problem hiding this comment.
You may want to include placementId in some of your tests.
There was a problem hiding this comment.
@hhhjort I have added placementId in the test.
Thanks
There was a problem hiding this comment.
Well, actually I was thinking in the parameters test where I made the comment.
adapters/infytv/infytv.go
Outdated
| "github.com/prebid/prebid-server/openrtb_ext" | ||
| ) | ||
|
|
||
| type Adapter struct { |
There was a problem hiding this comment.
Actually, we would prefer the name adapter. The beginning upper case letter tells Go to export this type and there is no need for that. Sorry to contradict with @hhhjort here.
There was a problem hiding this comment.
@SyntaxNode Updated to adapter.
| @@ -0,0 +1,9 @@ | |||
| maintainer: | |||
| email: "[email protected]" | |||
| capabilities: | |||
There was a problem hiding this comment.
I would like to confirm InfyTV does not have an IAB Europe GVL vendor id.
There was a problem hiding this comment.
@SyntaxNode Yes, InfyTV does not have an IAB Europe GVL vendor id.
* 'master' of https://github.com/wwwyyy/prebid-server: Read imp[].ext.tid, fix PBJS 7.3.0 compatibility (prebid#2283) New Adapter: Kargo (prebid#2268) VIS.X updated endpoint parameters (prebid#2282) New Adapter: InfyTV (prebid#2278) Support adapters to set seat for a bid (prebid#2266) VIS.X: add X-Forwarded-For header (prebid#2279) Unicorn: Revert limitation of JPY only ( add limitation of accountId ) (prebid#2277)
No description provided.