New Adapter: AndBeyondMedia #2322
Conversation
SyntaxNode
changed the title
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-04/schema#", | |||
| "title": "Compass Adapter Params", | |||
There was a problem hiding this comment.
Is this an alias of the Compass adapter? If so, we can advise on better ways to create the alias.
There was a problem hiding this comment.
@SyntaxNode thanks corrected the title. This is not an alias, this is a separate adapter
|
Hi @AndBeyondMediaHB. Thanks for your contribution. We're curious why you've copied the entire Compass adapter including config files and tests. We strongly prefer avoiding duplicate adapter code. |
|
@bsardo The solution might be the same as we outsourced it's development to the same team.But please approve our adapter as it's real and we really need to use it asap, and it's working with our platform. |
bsardo
requested review from
VeronikaSolovei9
and removed request for
SyntaxNode
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema#", | ||
| "title": "AndBeyond.Media Adapter Params", | ||
| "description": "A schema which validates params accepted by the Compass adapter", |
There was a problem hiding this comment.
Typo: Compass should be AndBeyondMedia.
| @@ -0,0 +1,14 @@ | |||
| maintainer: | |||
| email: "[email protected]" | |||
| capabilities: | |||
There was a problem hiding this comment.
I couldn't find a GVL ID for you in the vendor list. I just want to confirm that is the case, otherwise it should be specified here as gvlVendorID.
There was a problem hiding this comment.
thanks, we are not in the vendor list
| } | ||
|
|
||
| var invalidParams = []string{ | ||
| `{"placementId": 42}`, |
There was a problem hiding this comment.
Could you please add a test case to invalidParams of {} where neither placementId nor endpointId are provided since the bidder-params file specifies oneOf is required?
|
Local testing looks good. |
doc - prebid/prebid.github.io#3899