Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Tracking - Macro Replacement Framework #2623

Conversation

Pubmatic-Dhruv-Sonone
Copy link
Contributor

@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone commented Mar 6, 2023

Issue: #1725

This pr include changes for replacing macros in event tracking urls.

* OTT-421: Unit tests and basic framework for events consumption and validation
* OTT-421: Changed eventvalidation interface according to configuration.validate() requirements
* OTT-421: Made validate method from eventvalidation.go private

Co-authored-by: Shriprasad <[email protected]>
* OTT-421: Added note to not enabled this feature. Because, it is still in progress

Co-authored-by: Shriprasad <[email protected]>
OTT-422: Adding support for eventType=vast in analytic endpoint
…entscoments (#255)

* OTT-421: Addressed code review comments

Co-authored-by: Shriprasad <[email protected]>
…res) (#256)

* OTT-421: Fixed test failures

Co-authored-by: Shriprasad <[email protected]>
* OTT-421: Added warning when events.enabled is true

Co-authored-by: Shriprasad <[email protected]>
…ents - 2) (#258)

* OTT-421: Unit tests and basic framework for events consumption and validation

* OTT-421: Reverted unwanted change.

* OTT-421: Changed eventvalidation interface according to configuration.validate() requirements

* OTT-421: Reverted unwanted change

* OTT-421: Made validate method from eventvalidation.go private

* OTT-421: Added note to not enabled this feature. Because, it is still in progress

* OTT-421: Temporary print statement

* OTT-421: Addressed code review comments

* OTT-421: Fixed test failures

* OTT-421: Added warning when events.enabled is true

* OTT-421: Addressed code review comments

* OTT-421: Disabled event validations

* OTT-421: Reverted stored_requests/data/by_id/accounts/test.json

* OTT-421: Removed unwanted comment

Co-authored-by: Shriprasad <[email protected]>
* OTT-421: Disabled event validations
Co-authored-by: Shriprasad <[email protected]>
* OTT-422: Adding support for eventType=vast in analytic endpoint

* Adding test cases
* OTT-485: Macro Replacement framework
* OTT-485: Changes to support custom macros in req.ext.prebid.macros
* Truncating the custom macro value length to 100 chars
*Encoding macro values
* OTT-485: Adding benchmark
* Adding unit tests
@SyntaxNode SyntaxNode changed the title I1725 - Macro Replacement Framework Event Tracking - Macro Replacement Framework Mar 6, 2023
@bsardo bsardo self-assigned this Mar 6, 2023
@Pubmatic-Dhruv-Sonone
Copy link
Contributor Author

Closing this pr because of wrong base branch. Created new pr #2629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants