Medianet: Add fledge support #3641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adapters/medianet/medianet.go
Outdated
| return bidResponse, errs | ||
| } | ||
|
|
||
| // Builder builds a new instance of the Medianet adapter for the given bidder with the given config. | ||
| func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) { | ||
| url := buildEndpoint(config.Endpoint, config.ExtraAdapterInfo) | ||
| return &adapter{ | ||
| endpoint: url, | ||
| return &MedianetAdapter{ |
There was a problem hiding this comment.
You can call this simply "adapter", the MedianetAdapter identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be MedianetAdapter.MedianetAdapter which looks a little redundant. See example below:
package foo
type adapter struct {
endpoint string
}
func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
return &adapter{endpoint: "https://www.foo.com"}, nil
}
Code coverage summaryNote:
medianetRefer here for heat map coverage report |
Code coverage summaryNote:
medianetRefer here for heat map coverage report |
ghost
mentioned this pull request
adapters/medianet/medianet.go
Outdated
Comment on lines
139
to
141
| if err := json.Unmarshal(bidResp.Ext, &bidRespExt); err != nil { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
any particular reason to not return error from line 140
There was a problem hiding this comment.
Done, took error into consideration for assigning fledge config.
Code coverage summaryNote:
medianetRefer here for heat map coverage report |
|
PR tests are failing. |
|
PR author account has been deleted. Therefore closing this account 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Fledge support for Medianet adapter. The response from bidder for fledge auction config support the ortb format mentioned in the below link.
https://github.com/InteractiveAdvertisingBureau/openrtb/blob/main/extensions/community_extensions/Protected%20Audience%20Support.md