New Adapter: Copper6SSP #3755

Copper6SSP · 2024-06-16T20:20:15Z

github-actions · 2024-06-16T20:21:03Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 45a77cb

copper6ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:36:	MakeRequests	76.5%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:146:	getBidType	100.0%
total:										(statements)	86.6%

Copper6SSP · 2024-07-01T09:20:26Z

@bretg @onkarvhanumante @gargcreation1992 @bsardo @SyntaxNode @Sonali-More-Xandr please respond to this pull request

bsardo · 2024-07-05T14:34:18Z

Hi @Copper6SSP. Thanks for your patience. We've been quite busy due to summer vacations and internal priorities resulting in the delay. We'll review shortly.

Copper6SSP · 2024-07-16T18:52:52Z

@bsardo thanks for answering. Do you know any deadlines for reviewing a pull request?

adapters/copper6ssp/copper6ssp.go

bsardo · 2024-07-23T13:55:45Z

@bsardo thanks for answering. Do you know any deadlines for reviewing a pull request?

Hi @Copper6SSP, our pace has slowed significantly from the norm recently due to competing internal priorities and vacations. This is temporary. Peter reviewed and I will review sometime today. Sorry again for the delay.

przemkaczmarek

two nip comments

github-actions · 2024-07-24T08:49:46Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 248757e

copper6ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:36:	MakeRequests	77.1%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:93:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:111:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:147:	getBidType	100.0%
total:										(statements)	86.6%

Copper6SSP · 2024-07-24T08:49:58Z

two nip comments

updated

bsardo

This is looking good; I left a few minor comments.

bsardo · 2024-07-25T19:24:41Z

static/bidder-info/copper6ssp.yaml

@@ -0,0 +1,21 @@
+endpoint: "https://endpoint.copper6.com/"
+maintainer:
+  email: "[email protected]"


We've sent an email to this address to confirm it is correct. Please respond to the email with a "received" message.

adapters/copper6ssp/copper6ssp_test.go

adapters/copper6ssp/copper6ssp.go

adapters/copper6ssp/copper6ssptest/exemplary/simple-banner.json

adapters/copper6ssp/copper6ssptest/exemplary/multi-imp.json

static/bidder-info/copper6ssp.yaml

github-actions · 2024-08-05T13:59:41Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ef0e3a3

copper6ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:145:	getBidType	100.0%
total:										(statements)	92.4%

Copper6SSP · 2024-08-05T14:03:00Z

@bsardo @przemkaczmarek fixed all, review please

adapters/copper6ssp/copper6ssptest/exemplary/multi-imp.json

github-actions · 2024-08-12T11:15:56Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, e2eb39a

copper6ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:145:	getBidType	100.0%
total:										(statements)	92.4%

adapters/copper6ssp/copper6ssptest/exemplary/multi-imp.json

bsardo · 2024-08-14T15:25:50Z

Hi @Copper6SSP, we noticed that your adapter is basically the same as the Playdigo and QT adapters that were recently merged into the project, as well as the Oraki adapter that is currently under review. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.

Please let us know your thoughts on whether this is a possibility for you.

github-actions · 2024-08-21T15:14:14Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7762ff5

copper6ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:145:	getBidType	100.0%
total:										(statements)	92.4%

Copper6SSP · 2024-08-21T16:37:49Z

Hi @Copper6SSP, we noticed that your adapter is basically the same as the Playdigo and QT adapters that were recently merged into the project, as well as the Oraki adapter that is currently under review. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.

Please let us know your thoughts on whether this is a possibility for you.

@bsardo Thanks for the review. Unfortunately, this does not suit us, since we have separate servers that do not belong to the above mentioned adapters.

przemkaczmarek · 2024-08-23T04:57:16Z

adapters/copper6ssp/copper6ssptest/exemplary/multi-imp.json

+                }
+            },
+            {
+                "id": "test-imp-id2",


Copper6SSP added 2 commits June 16, 2024 23:16

release adapter Copper6SSP

50df45a

upd

45a77cb

bretg requested a review from przemkaczmarek July 23, 2024 13:33

bretg assigned przemkaczmarek Jul 23, 2024

przemkaczmarek reviewed Jul 23, 2024

View reviewed changes

adapters/copper6ssp/copper6ssp.go Outdated Show resolved Hide resolved

przemkaczmarek reviewed Jul 23, 2024

View reviewed changes

adapters/copper6ssp/copper6ssp.go Outdated Show resolved Hide resolved

bsardo self-assigned this Jul 23, 2024

przemkaczmarek reviewed Jul 23, 2024

View reviewed changes

Copper6SSP added 2 commits July 24, 2024 11:43

Merge remote-tracking branch 'prebid/master'

00f8062

upd

248757e

Copper6SSP requested a review from przemkaczmarek July 24, 2024 08:49

przemkaczmarek previously approved these changes Jul 24, 2024

View reviewed changes

bretg unassigned bsardo Jul 29, 2024

przemkaczmarek requested a review from bsardo July 29, 2024 15:31

bsardo self-assigned this Jul 29, 2024

bsardo changed the title ~~Copper6SSP: new adapter~~ New Adapter: Copper6SSP Jul 31, 2024

bsardo reviewed Jul 31, 2024

View reviewed changes

bsardo reviewed Aug 2, 2024

View reviewed changes

static/bidder-info/copper6ssp.yaml Show resolved Hide resolved

static/bidder-info/copper6ssp.yaml Show resolved Hide resolved

Copper6SSP added 2 commits August 5, 2024 15:36

Merge remote-tracking branch 'prebid/master'

39dc530

fixes

ef0e3a3

Copper6SSP dismissed przemkaczmarek’s stale review via ef0e3a3 August 5, 2024 13:58

Copper6SSP requested review from bsardo and przemkaczmarek August 5, 2024 13:59

przemkaczmarek previously approved these changes Aug 6, 2024

View reviewed changes

bsardo reviewed Aug 6, 2024

View reviewed changes

adapters/copper6ssp/copper6ssptest/exemplary/multi-imp.json Outdated Show resolved Hide resolved

upd test

57ead97

Copper6SSP dismissed przemkaczmarek’s stale review via 57ead97 August 12, 2024 11:10

Copper6SSP requested review from bsardo and przemkaczmarek August 12, 2024 11:11

fixes

e2eb39a

bsardo reviewed Aug 14, 2024

View reviewed changes

adapters/copper6ssp/copper6ssptest/exemplary/multi-imp.json Show resolved Hide resolved

upd

7762ff5

Copper6SSP requested a review from bsardo August 21, 2024 16:37

bsardo approved these changes Aug 22, 2024

View reviewed changes

przemkaczmarek reviewed Aug 23, 2024

View reviewed changes

adapters/copper6ssp/copper6ssptest/exemplary/multi-imp.json

}

},

{

"id": "test-imp-id2",

Copy link

Collaborator

przemkaczmarek Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

przemkaczmarek approved these changes Aug 23, 2024

View reviewed changes

bsardo merged commit 4ea0e33 into prebid:master Aug 30, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Aug 30, 2024

Port PR from PBS-Go: New Adapter: Copper6SSP prebid/prebid-server-java#3411

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: Copper6SSP #3755

New Adapter: Copper6SSP #3755

Copper6SSP commented Jun 16, 2024

github-actions bot commented Jun 16, 2024

Copper6SSP commented Jul 1, 2024

bsardo commented Jul 5, 2024

Copper6SSP commented Jul 16, 2024

bsardo commented Jul 23, 2024

przemkaczmarek left a comment

github-actions bot commented Jul 24, 2024

Copper6SSP commented Jul 24, 2024

bsardo left a comment

bsardo Jul 25, 2024

Copper6SSP Aug 5, 2024

github-actions bot commented Aug 5, 2024

Copper6SSP commented Aug 5, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024

bsardo commented Aug 14, 2024

github-actions bot commented Aug 21, 2024

Copper6SSP commented Aug 21, 2024

przemkaczmarek Aug 23, 2024

New Adapter: Copper6SSP #3755

New Adapter: Copper6SSP #3755

Conversation

Copper6SSP commented Jun 16, 2024

github-actions bot commented Jun 16, 2024

Code coverage summary

copper6ssp

Copper6SSP commented Jul 1, 2024

bsardo commented Jul 5, 2024

Copper6SSP commented Jul 16, 2024

bsardo commented Jul 23, 2024

przemkaczmarek left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 24, 2024

Code coverage summary

copper6ssp

Copper6SSP commented Jul 24, 2024

bsardo left a comment

Choose a reason for hiding this comment

bsardo Jul 25, 2024

Choose a reason for hiding this comment

Copper6SSP Aug 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2024

Code coverage summary

copper6ssp

Copper6SSP commented Aug 5, 2024 • edited Loading

github-actions bot commented Aug 12, 2024

Code coverage summary

copper6ssp

bsardo commented Aug 14, 2024

github-actions bot commented Aug 21, 2024

Code coverage summary

copper6ssp

Copper6SSP commented Aug 21, 2024

przemkaczmarek Aug 23, 2024

Choose a reason for hiding this comment

Copper6SSP commented Aug 5, 2024 •

edited

Loading