Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: TradPlus #3838

Closed
wants to merge 1 commit into from
Closed

New Adapter: TradPlus #3838

wants to merge 1 commit into from

Conversation

tradplus
Copy link

@tradplus tradplus commented Aug 2, 2024

TradPlus is a leading, stable, and reliable ad monetization platform that is committed to providing global developers with fair, transparent and efficient monetization solutions. We also provide ADX and Saas ADX services. We serve 2,000+ global developers. Moreover, Our SDK has been certified by IAB Tech Lab and also joins Google Play SDK Index. And we have Information Security Management Certification.

Our advertising business spans the world. This is our official website: https://tradplusad.com/en. You can get more details about TradPlus.

this is TradPlus adapter version 1.0.

Thank!

Copy link

github-actions bot commented Aug 2, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5d43c55

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:33:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:41:	makeRequest		78.9%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:80:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:98:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:106:	transform		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:131:	validateTradPlusExt	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:155:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:186:	getMediaTypeForBid	80.0%
total:									(statements)		87.9%

return nil, errs
}

tradplusExt, err := getImpressionExt(&request.Imp[0])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tradplus Can you please confirm if you want to use ext of first impression even in case of multiple imps? If that is the case then validateTradPlusExt() function can be only used for first imp rather than looping over all the imps or validation for accountId can be done in getImpressionExt() function itself and return error from getImpressionExt()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the validateTradPlusExt method has been deleted.

@onkarvhanumante
Copy link
Contributor

PR is inactive for more than 3-4 weeks. Therefore, closing this PR.

@tradplus, reopen this PR after addressing open comments or making code changes.

@tradplus
Copy link
Author

tradplus commented Sep 6, 2024

Sorry for the delayed reply, the issue has been fixed, please reopen this PR.

@Compile-Ninja
Copy link

@tradplus Also please take a look on Java implementation
prebid/prebid-server-java#3361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants