Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Oraki #3839

Merged
merged 3 commits into from
Aug 30, 2024
Merged

New Adapter: Oraki #3839

merged 3 commits into from
Aug 30, 2024

Conversation

BenOraki
Copy link
Contributor

@BenOraki BenOraki commented Aug 6, 2024

Copy link

github-actions bot commented Aug 6, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b33f8d4

oraki

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:35:	MakeRequests	74.2%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:85:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:103:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:140:	getBidType	100.0%
total:								(statements)	85.9%

@bsardo bsardo changed the title Oraki: reopen New Adapter: Oraki Aug 8, 2024
@@ -0,0 +1,18 @@
endpoint: "https://eu1.oraki.io/pserver"
maintainer:
email: "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent email for verification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email verified.

@@ -0,0 +1,18 @@
endpoint: "https://eu1.oraki.io/pserver"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is reachable.

@bsardo
Copy link
Collaborator

bsardo commented Aug 14, 2024

Hi @BenOraki, we noticed that your adapter is basically the same as the Playdigo and QT adapters that were recently merged into the project, as well as the Copper6SSP adapter that is currently under review. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.

Please let us know your thoughts on whether this is a possibility for you.

@BenOraki
Copy link
Contributor Author

Hi @bsardo, we do not share the same server with any of the adapters you mentioned. So we cannot use aliases. This pull request is very time-sensitive, and we must get it out as soon as possible. However, I will consider some methods of code duplication reduction in the future for our adapter.

@przemkaczmarek przemkaczmarek self-requested a review August 21, 2024 13:34
- video
- native
userSync:
redirect:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usersync works!

https://sync.oraki.io/pbserver?gdpr=&gdpr_consent=&us_privacy=&gpp=&gpp_sid=&redir=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Doraki%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Di%26uid%3D%5BUID%5D

@BenOraki
Copy link
Contributor Author

@gargcreation1992 I see that this PR has been approved. Can it be merged now?

@bsardo
Copy link
Collaborator

bsardo commented Aug 22, 2024

Hi @BenOraki, we just got a second approval so your PR is ready to merge. I'm holding off on doing so at the moment until I fix a critical issue with the latest release and then we will merge this in.

@BenOraki
Copy link
Contributor Author

Hi @bsardo, why wasn’t this PR included in the last release?

@bsardo
Copy link
Collaborator

bsardo commented Aug 30, 2024

@BenOraki we had a freeze on merging PRs for the last release due to the critical issue mentioned earlier. This is being merged now and will be part of v2.29.0.

@bsardo bsardo merged commit e825553 into prebid:master Aug 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants