Fix Agma Module Shutdown() test #3844
Open
+33
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guscarreon
commented
Sep 5, 2024
| glog.Warning("[AgmaAnalytics] fail to copy the buffer") | ||
| return | ||
| } | ||
|
|
||
| go l.sender(payload) | ||
|
|
||
| l.reset() | ||
| l.mux.Unlock() |
There was a problem hiding this comment.
Given that payload is a copy, l.reset() and l.mux.Unlock() should be moved upstream so the memory is unlocked and available for other processes in case go l.sender(payload) gets run before the remainder of flush().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
TestShutdownFlushsometimes fails theAssertCalled()check when run from thevalidate.shscript due to a race condition that thetime.Sleep()call in line 697 is unable to avoid if the goroutinego l.sender(payload)insideflush()takes longer to get run by golang's goroutine scheduler than the 10 millisecond wait.This pull request refactors
TestShutdownFlushso nogo l.sender(payload)goroutine gets called so the occurence of a race condition is less likely.