Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonobi: native and currency conversion support #3889

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sonobi: native and currency conversion support #3889

wants to merge 3 commits into from

Conversation

bansawbanchee
Copy link

@bansawbanchee bansawbanchee commented Aug 27, 2024 •
edited
Loading

Closed previous pull request. Put everything in one. Native and currency conversion support.

We were asked to use mtype for determining the mediatype. We currently do not support mtype from our server so I removed that function for now. Once we support it I will update our adapter.

@bansawbanchee bansawbanchee mentioned this pull request Aug 27, 2024
Closed
@bansawbanchee bansawbanchee force-pushed the sonobi-currency-update-native-support branch from 349c343 to 4122f2f Compare August 27, 2024 17:49
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4122f2f

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests	66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids	71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:155:	getBidType	50.0%
total:									(statements)	69.2%

@bansawbanchee bansawbanchee force-pushed the sonobi-currency-update-native-support branch from 4122f2f to e42e7de Compare August 27, 2024 18:08
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e42e7de

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests	66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids	71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:155:	getBidType	50.0%
total:									(statements)	69.2%

@bansawbanchee bansawbanchee force-pushed the sonobi-currency-update-native-support branch from e42e7de to 944313d Compare August 27, 2024 18:14
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 944313d

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:156:	getMediaTypeForImp	77.8%
total:									(statements)		72.1%

@bansawbanchee bansawbanchee force-pushed the sonobi-currency-update-native-support branch from 944313d to ab63a76 Compare August 27, 2024 18:21
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ab63a76

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:157:	getMediaTypeForImp	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:176:	getBidType		0.0%
total:									(statements)		66.2%

@bansawbanchee bansawbanchee force-pushed the sonobi-currency-update-native-support branch from ab63a76 to 64dc827 Compare August 27, 2024 18:44
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 64dc827

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:157:	getMediaTypeForImp	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:176:	getBidType		0.0%
total:									(statements)		66.2%

@bansawbanchee bansawbanchee force-pushed the sonobi-currency-update-native-support branch from 64dc827 to fc4db51 Compare August 27, 2024 19:17
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, fc4db51

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:157:	getMediaTypeForImp	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:176:	getBidType		0.0%
total:									(statements)		66.2%

@bsardo
Copy link
Collaborator

bsardo commented Sep 17, 2024

Hi @bansawbanchee, now that the review process has started, please push new commits instead of rebasing and force pushing to save reviewers time. Thanks!

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, dffa78c

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		75.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:156:	getMediaTypeForImp	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:175:	getBidType		0.0%
total:									(statements)		67.1%

@bsardo bsardo self-assigned this Sep 19, 2024
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 835d0e0

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		75.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:155:	getMediaTypeForImp	77.8%
total:									(statements)		73.1%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@bsardo bsardo

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bansawbanchee @bsardo @przemkaczmarek