Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Kobler #3904

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New Adapter: Kobler #3904

wants to merge 3 commits into from

Conversation

TommyHPettersen
Copy link

* New Adapter: Kobler
var bidExt openrtb_ext.ExtBid
err := json.Unmarshal(bid.Ext, &bidExt)
if err == nil && bidExt.Prebid != nil {
mediaType, err := openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c65ede1

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:35:	MakeRequests		85.7%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:67:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:98:	getEndpoint		100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:106:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:121:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:135:	contains		50.0%
total:									(statements)		92.2%

@bsardo bsardo self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants