Fix goroutine leak in hooks execution group #3911
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function creates an unbuffered channel
prebid-server/hooks/hookexecution/execution.go
Line 70 in ec6a45d
If hook returns Reject error the
collectHookResponses
aborts reading of the channelprebid-server/hooks/hookexecution/execution.go
Line 138 in ec6a45d
and this results to dead goroutine in
prebid-server/hooks/hookexecution/execution.go
Line 76 in ec6a45d
#3754