InMobi: mtype support #3921
Open
InMobi: mtype support #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
inmobiRefer here for heat map coverage report |
Code coverage summaryNote:
inmobiRefer here for heat map coverage report |
riteshghodrao
approved these changes
Sep 19, 2024
przemkaczmarek
previously approved these changes
Sep 19, 2024
bsardo
reviewed
Sep 19, 2024
adapters/inmobi/inmobi.go
Outdated
Comment on lines
131
to
132
| default: | ||
| return openrtb_ext.BidTypeBanner |
There was a problem hiding this comment.
It appears you were defaulting to banner before adding mtype support but now that you have it, is your server supposed to always set it? If so, you might want to do what most other adapters do which is to return an error if mtype does not equal one of your supported formats.
default:
return "", fmt.Errorf("unrecognized bid type in response from inmobi for bid %s", bid.ImpID)
and then in the calling code:
mediaType, err := getMediaTypeForImp(sb.Bid[i].ImpID, internalRequest.Imp)
if err != nil {
return nil, []error{err}
}
Thoughts?
There was a problem hiding this comment.
Sounds good. I've made the recommended changes.
Code coverage summaryNote:
inmobiRefer here for heat map coverage report |
bsardo
reviewed
Sep 20, 2024
adapters/inmobi/inmobi.go
Outdated
Comment on lines
130
to
131
| case openrtb2.MarkupAudio: | ||
| return openrtb_ext.BidTypeAudio, nil |
There was a problem hiding this comment.
You haven't declared audio support in your YAML file so it might be best to remove this and let this case result in an error.
Code coverage summaryNote:
inmobiRefer here for heat map coverage report |
bsardo
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.