Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectAd: String/int fix #3925

Merged
merged 1 commit into from
Sep 19, 2024
Merged

ConnectAd: String/int fix #3925

merged 1 commit into from
Sep 19, 2024

Conversation

rtuschkany
Copy link
Contributor

fix to support string and int values as SiteID/NetworkID

fix to support string and int values as SiteId/NetworkId
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1932591

connectad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:29:	MakeRequests		95.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:73:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:107:	preprocess		100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:141:	addImpInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:151:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:157:	unpackImpExt		88.9%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:181:	buildImpBanner		100.0%
total:									(statements)		97.6%

@onkarvhanumante onkarvhanumante self-assigned this Sep 17, 2024
@bsardo bsardo merged commit 93368cc into prebid:master Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants