Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equativ: Update bid type computation with Markup type #4045

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rneuplanche
Copy link

In order to support correctly multi impression type bid request, we need to change the way we compute the BidType in the Equativ adapter

Copy link

github-actions bot commented Nov 8, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f743645

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:	MakeRequests			85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161:	BuildEndpointURL		83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175:	getBidTypeFromMarkupType	83.3%
total:										(statements)			88.6%

Copy link

github-actions bot commented Nov 8, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 437b9e1

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:	MakeRequests			85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161:	BuildEndpointURL		83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175:	getBidTypeFromMarkupType	83.3%
total:										(statements)			88.6%

Copy link

github-actions bot commented Nov 8, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6b13b58

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:	MakeRequests			85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161:	BuildEndpointURL		83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175:	getBidTypeFromMarkupType	83.3%
total:										(statements)			88.6%

@rneuplanche rneuplanche marked this pull request as ready for review November 8, 2024 19:45
Copy link

github-actions bot commented Nov 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d288bec

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:	MakeRequests			85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161:	BuildEndpointURL		83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175:	getBidTypeFromMarkupType	83.3%
total:										(statements)			88.6%

Copy link

@mdaddario-STR mdaddario-STR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this take care of prebid server v2 and v3?

@rneuplanche
Copy link
Author

Looks good. Does this take care of prebid server v2 and v3?
@mdaddario-STR

Not sure if the Prebid team is still publishing updates on PBS V2 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants