Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce currency support in adapters bid responses as described in #280. #491

Merged
merged 1 commit into from
May 4, 2018
Merged

Introduce currency support in adapters bid responses as described in #280. #491

merged 1 commit into from
May 4, 2018

Commits on May 4, 2018

  1. This CL introduces currency declaration support in adapters bid respo… 

    …nses as described in prebid#280.

This change covers:
* Introducing a new struct `BidderResponse` carrying the list of bids `TypedBid` and a currency as string
* Change the existing adapters using the new API `MakeBids` so it start using the new `BidderResponse` struct

This change doesn't cover:
* Doesn't change the former API using `Call` method
* Any check done on Pre-bid server side to discard any bid received with an invalid currency
  (such as unknown, or a one that wasn't authorized in a first place via trhe bid request)
* Any mechanisms on tranlating currency rates

As a nice next step, we should implement the mechanism to filter bids having invalid currencies on not allowed ones.
It will allow to protect both parties from currencies mismatch / discrepancies.
    Benjamin Chastanier committed May 4, 2018
    Configuration menu
    Copy the full SHA
    0ad0d1b View commit details
    Browse the repository at this point in the history