[Sharethrough] Add new Sharethrough Adapter #903

maphe · 2019-05-15T19:00:07Z

Sharethrough is adding a new adapter.

This follows guidelines from http://prebid.org/prebid-server/developers/add-new-bidder.html

Updating from head repo

…/add_str_bidder

Co-authored-by: Chris Nguyen <[email protected]>

#164291358 Co-authored-by: Josh Becker <[email protected]>

[#164291358] Co-authored-by: Josh Becker <[email protected]>

[#164291358] Co-authored-by: Eddy Pechuzal <[email protected]>

Initial implementation for STR Adapter

todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]>

[#164291358]

Add s2s-win beacon

[#165257793]

* Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574]

* Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <[email protected]> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <[email protected]> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <[email protected]> Co-authored-by: Josh Becker <[email protected]> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <[email protected]>

[#165477915]

[#164911891] Co-authored-by: Josh Becker <[email protected]>

… sharethrough_master # Conflicts: # exchange/adapter_map.go # openrtb_ext/bidders.go

adapters/sharethrough/sharethrough.go

adapters/sharethrough/butler.go

adapters/sharethrough/sharethrough.go

adapters/sharethrough/utils.go

@mansinahar

Optimizations, clean up suggested by @mansinahar

maphe · 2019-06-03T22:47:37Z

Thank you @mansinahar for the feedbacks and suggestions, I was able to address everything beside getting the right prebid-server version; that won't break anything though, we would just log incorrect data on our side but we could live with it until we find a way to get the correct value

mansinahar · 2019-06-04T15:58:34Z

@maphe Thank you. Appreciate the PR :)

* Addressing June 4th review from #903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible

maphe · 2019-06-04T18:05:16Z

@hhhjort @mansinahar @guscarreon @josephveach thanks again for your help and reviews, everything has been addressed at this point. Hopefully this is in an approvable state, trying to make it into the next release...

adapters/sharethrough/butler.go

mansinahar · 2019-06-04T18:26:16Z

@maphe Thanks for addressing all the comments. There's just one other minor comment you might wanna take care of. Other than that it LGTM!

maphe · 2019-06-04T19:28:45Z

Thanks @mansinahar, this is addressed now 👍

maphe · 2019-06-05T17:18:12Z

Would any of you be able to provide an ETA for when we can expect the PR to be merged? assuming there are no more changes required...

guscarreon

LGTM

josephveach · 2019-06-13T20:21:49Z

@maphe Apologies for reopening this issue: We all failed to notice that, assuming your adapter makes HTTP calls using standard JSON, there should be tests in adapters/sharethrough/sharethroughtest/ using the tool described here: https://github.com/prebid/prebid-server/blob/master/adapters/adapterstest/test_json.go#L50 and referenced here: https://github.com/prebid/prebid-server/blob/master/docs/developers/automated-tests.md under Adapter Tests. Please see pretty much any other adapter's code in the corresponding directory for examples.

Such tests can detect a wide range of issues and also serve to help other people understand what is and is not supposed to work as a request for your adapter. Can you please submit some of these types of tests when you get a chance, or let us know if they would not be applicable?

maphe · 2019-06-13T21:38:07Z

@josephveach thanks for reaching out, I'm looking at the links you shared, although I'm not sure it applies to us. Our adapter actually uses query params and not JSON body, as you can see around this line https://github.com/prebid/prebid-server/blob/master/adapters/sharethrough/butler.go#L88

Can you confirm we cannot leverage this test framework for our adapter?

@mansinahar

* Use the correct labels for cache performance metric (prebid#904) * PubMatic Adslot validation (prebid#886) * testing a few changes to validate adslot, more to follow * Changed AdSlot to optional parameter, modified validation and test cases for the same * removed imp id from adslot validation error msgs * assign banner size * remove TrimSpace where it is not needed as recommended in the review * Implementation of Categories Http fetcher (prebid#882) * Implementation of Categories Http fetcher -Added code to fetch data using http -Added previously loaded categories to run http request just at the first time * Moved common Category struct to stored_request * Added comments * Minor refactoring * Minor refactoring -Added verification if category exist in map * Minor refactoring * Minor refactoring -strings.Replace changed to strings.TrimSuffix * Improved error handling on Beachfront adapter (prebid#873) * Removed a redundant error message that was causing some confusion. * trying to turn '[]' into null and 200 inti 404 * not a goot path * looking at the status codes * I think I have covers all these bases. * checking for empty array response a failing sanely * removed an attempt to pointlessly reset the status code. * corrected and added test cases * Fix Rubicon bidder for multi-format impression processing (prebid#902) * Replace Dockerfile Alpine linux with Ubuntu (prebid#885) * Ubuntu dockerfile works, includes backups and out file * Ubuntu Dockerfile creates image successfully and prebid-server was tested with a sample request. Seems to work fine * Ubuntu 18.04 now builds, validates.sh, and curls sample request successfully * Removed sed command * [fix] broken Go 1.9 compatibility (prebid#910) This CL addresses Go 1.9 compatibility issue along with adding back Go 1.9 to travis testing setup to prevent such bugs. Issue: prebid#895 * Fixed "invalid BidType: " error for lifestreet adapter (prebid#893) * Fixed "invalid BidType: " error for lifestreet adapter * After run gofmt * Used standard bid.ext type to get bid.ext.prebid.type * [Currency support] Activate multi-currencies support (prebid#894) This CL is the last piece to activate currency conversion support in PBS. It activates currency support per default. Currency rates will be fetched once per hour (PrebidJS file is updated once a day). Issue: prebid#280 * ImproveDigital adapter: (prebid#887) - Add support for video - Add support for mobile/app - Add support for multibid responses - Extend optional parameters * Add a PI exemption environment variable to PBS (prebid#916) * Refactored to official name of config item * Changes suggested by Mansi Nahar * [Sharethrough] Add new Sharethrough Adapter (prebid#903) * wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <[email protected]> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <[email protected]> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <[email protected]> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <[email protected]> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <[email protected]> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (prebid#4) [#165257793] * Proper error handling (prebid#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (prebid#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <[email protected]> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <[email protected]> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <[email protected]> Co-authored-by: Josh Becker <[email protected]> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <[email protected]> * Send supplyId to imp req instead of hbSource (prebid#5) [#165477915] * Finalize PR (prebid#8) [#164911891] Co-authored-by: Josh Becker <[email protected]> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (prebid#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (prebid#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling * [Mgid] Add new Mgid Adapter (prebid#907) * new mgid adapter * increase coverage * remove extra imports * Cache validation fix (prebid#911) * Cache validation fix if no bids returned - don't throw cache error, just return empty result * Cache validation fix - optimization: do not run auction logic if no bids returned * Cache validation fix: minor refactoring * Cache validation fix: minor refactoring * Cache validation fix: added unit test for no bids returned * Cache validation fix: minor refactoring * Remove hard coded targeting keys (prebid#923)

josephveach · 2019-06-14T19:31:41Z

@maphe Confirmed. There's no need for the JSON tests given how your adapter behaves. Sorry about the false alarm!

maphe · 2019-06-14T19:37:01Z

Cool, thanks @josephveach

hhhjort · 2019-06-14T19:39:39Z

Actually, you may be able to/ the adapters/adaptertest/test_josn.go:218 diffHttpRequests() function will compare URIs directly, and the bodies separately. I am guessing that setting the expected body to be an empty string, may match the actual empty body you generate, and thus pass the test. It would definitely test that you are generating the correct URIs.

maphe · 2019-06-14T19:42:50Z

Fair enough, I'll try it out...

maphe · 2019-06-14T23:47:49Z

@josephveach @hhhjort just a heads up, I pushed a new PR that fixes a more urgent separate issue (#938), it does not have what was discussed above. I'll try this test_json stuff next week and push another PR if relevant, I'll let you know. Thanks again

@mansinahar

* wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <[email protected]> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <[email protected]> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <[email protected]> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <[email protected]> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <[email protected]> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (#4) [#165257793] * Proper error handling (#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <[email protected]> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <[email protected]> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <[email protected]> Co-authored-by: Josh Becker <[email protected]> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <[email protected]> * Send supplyId to imp req instead of hbSource (#5) [#165477915] * Finalize PR (#8) [#164911891] Co-authored-by: Josh Becker <[email protected]> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling

@mansinahar

* wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <[email protected]> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <[email protected]> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <[email protected]> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <[email protected]> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <[email protected]> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (#4) [#165257793] * Proper error handling (#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <[email protected]> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <[email protected]> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <[email protected]> Co-authored-by: Josh Becker <[email protected]> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <[email protected]> * Send supplyId to imp req instead of hbSource (#5) [#165477915] * Finalize PR (#8) [#164911891] Co-authored-by: Josh Becker <[email protected]> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling

maphe and others added 27 commits March 18, 2019 16:43

Merge pull request #1 from prebid/master

561bbc9

Updating from head repo

wip

81781cf

wip

9e5f5cc

wip

90879cc

exploration for sharethrough prebid-server

1749761

Merge remote-tracking branch 'sharethrough/cn/add_str_bidder' into cn…

3118800

…/add_str_bidder

WIP: updating sharethrough adapter to latest prebid version

67436b0

Co-authored-by: Chris Nguyen <[email protected]>

WIP: adding butler params to the request

3b15444

#164291358 Co-authored-by: Josh Becker <[email protected]>

Manage bid sizes

49002fb

[#164291358] Co-authored-by: Josh Becker <[email protected]>

Manage GDPR

8d4fff0

[#164291358] Co-authored-by: Josh Becker <[email protected]>

Populate prebid-server version if provided

e492203

[#164291358] Co-authored-by: Josh Becker <[email protected]>

Refactor gdpr data extraction from request

edc8d76

[#164291358] Co-authored-by: Eddy Pechuzal <[email protected]>

Add instant play capability

c9301b4

[#164291358] Co-authored-by: Eddy Pechuzal <[email protected]>

Split in multiple files

1b20442

[#164291358] Co-authored-by: Eddy Pechuzal <[email protected]>

Merge pull request #2 from sharethrough/cn/add_str_bidder

962666d

Initial implementation for STR Adapter

Add s2s-win beacon

665ae99

todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]>

Removing server param in s2s-win beacon (will be added in imp req)

c6cefa5

[#164291358]

Merge pull request #3 from sharethrough/mp-ep/add-s2s-win-beacon

311d1a4

Add s2s-win beacon

Clean up code + enable syncer (#4)

6800634

[#165257793]

Proper error handling (#6)

93756ef

* Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574]

Send supplyId to imp req instead of hbSource (#5)

44455a2

[#165477915]

Finalize PR (#8)

a17beca

[#164911891] Co-authored-by: Josh Becker <[email protected]>

Merge branch 'master' of https://github.com/prebid/prebid-server into…

0b73d0e

… sharethrough_master # Conflicts: # exchange/adapter_map.go # openrtb_ext/bidders.go

Remove test setting

0d58bb0

Add Sharethrough in syncer_test

60ecbde

Update deserializing of third party partners

23686e3

hhhjort requested review from hhhjort, guscarreon and josephveach May 28, 2019 15:30

hhhjort previously approved these changes Jun 3, 2019

View reviewed changes

josephveach previously approved these changes Jun 3, 2019

View reviewed changes

mansinahar reviewed Jun 3, 2019

View reviewed changes

guscarreon requested changes Jun 3, 2019

View reviewed changes

adapters/sharethrough/utils.go Show resolved Hide resolved

Addressing June 3rd review from #903

5aac9ec

Optimizations, clean up suggested by @mansinahar

maphe dismissed stale reviews from josephveach and hhhjort via 5aac9ec June 3, 2019 22:29

Addressing June 4th review from #903 (#10)

3caa28e

* Addressing June 4th review from #903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible

mansinahar reviewed Jun 4, 2019

View reviewed changes

adapters/sharethrough/butler.go Outdated Show resolved Hide resolved

Fix adMarkup error handling

55f03f0

josephveach approved these changes Jun 4, 2019

View reviewed changes

mansinahar approved these changes Jun 5, 2019

View reviewed changes

guscarreon approved these changes Jun 5, 2019

View reviewed changes

hhhjort merged commit 71915a4 into prebid:master Jun 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Sharethrough] Add new Sharethrough Adapter #903

[Sharethrough] Add new Sharethrough Adapter #903

maphe commented May 15, 2019

maphe commented Jun 3, 2019

mansinahar commented Jun 4, 2019

maphe commented Jun 4, 2019

mansinahar commented Jun 4, 2019

maphe commented Jun 4, 2019

maphe commented Jun 5, 2019

guscarreon left a comment

josephveach commented Jun 13, 2019

maphe commented Jun 13, 2019

josephveach commented Jun 14, 2019

maphe commented Jun 14, 2019

hhhjort commented Jun 14, 2019

maphe commented Jun 14, 2019

maphe commented Jun 14, 2019

[Sharethrough] Add new Sharethrough Adapter #903

[Sharethrough] Add new Sharethrough Adapter #903

Conversation

maphe commented May 15, 2019

maphe commented Jun 3, 2019

mansinahar commented Jun 4, 2019

maphe commented Jun 4, 2019

mansinahar commented Jun 4, 2019

maphe commented Jun 4, 2019

maphe commented Jun 5, 2019

guscarreon left a comment

Choose a reason for hiding this comment

josephveach commented Jun 13, 2019

maphe commented Jun 13, 2019

josephveach commented Jun 14, 2019

maphe commented Jun 14, 2019

hhhjort commented Jun 14, 2019

maphe commented Jun 14, 2019

maphe commented Jun 14, 2019