Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Prebid VOX Bidder Adapter #2534

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

hybrid-ai
Copy link
Contributor

@hybrid-ai hybrid-ai commented Nov 25, 2020

This is the documentation for voxBidAdapter.js prebid/Prebid.js#6030

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but we don't want the full HTML examples in bidder documentation. The page at https://docs.prebid.org/dev-docs/bidders.html is almost 2MB already and quite long.

Hang on and we'll come up with another place to put these examples and then you can link to them.

@hybrid-ai
Copy link
Contributor Author

Thank you for your comment. We fixed it.

@bretg
Copy link
Contributor

bretg commented Jan 8, 2021

part of 4.21

@bretg bretg merged commit a34d16c into prebid:master Jan 8, 2021
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Jan 21, 2021
* Documentation for Prebid VOX Bidder Adapter

* Deleted the full HTML examples

Co-authored-by: s-shevtsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants