Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppNexus: Added info for generate_ad_pod_id #2836

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

VeronikaSolovei9
Copy link
Contributor

No description provided.

@@ -56,6 +56,7 @@ All AppNexus placements included in a single call to `requestBids` must belong t
| `pubClick` | optional | Specifies a publisher-supplied URL for third-party click tracking. This is just a placeholder into which the publisher can insert their own click tracker. This parameter should be used for an unencoded tracker. This parameter is expected to be the last parameter in the URL. Please note that the click tracker placed in this parameter will only fire if the creative winning the auction is using AppNexus click tracking properly. | `'http://click.adserver.com/'` | `string` |
| `extInvCode` | optional | Specifies predefined value passed on the query string that can be used in reporting. The value must be entered into the system before it is logged. | `'10039'` | `string` |
| `externalImpId` | optional | Specifies the unique identifier of an externally generated auction. | `'bacbab02626452b097f6030b3c89ac05'` | `string` |
| `generate_ad_pod_id`| optional | Signal to AppNexus to split impressions by ad pod and add unique ad pod id to each request. Specific to long form video endpoint only. | `true` | `boolean` |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to change it to Intended for long form video endpoint only.. There doesn't seem to be anything to prevent it being used in non-long form video, but also does not make sense in this context either. Perhaps someone will come up with a smart twist that uses this on the main openrtb endpoint.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be ignored for non-long form video because the code branch is only activated for /video traffic. I like the idea of adding the long form video endpoint only note. I'd also think it's important to note this is only supported by PBS and not PBJS (there's no need on the PBJS side as far as I'm aware).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified.

@bretg bretg changed the title Added info for generate_ad_pod_id AppNexus: Added info for generate_ad_pod_id Apr 22, 2021
@bretg bretg requested review from SyntaxNode and hhhjort June 3, 2021 16:54
Copy link

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jeanstemp jeanstemp merged commit 09b14c4 into prebid:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants