Feature: allowSendAllTargetingKeys #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why are there so many changes here, are you working off an old copy? |
ghost
force-pushed
the
feature/allowSendAllTargetingKeys
branch
2 times, most recently
from
8736d44
to
3a123ad
Compare
ghost
force-pushed
the
feature/allowSendAllTargetingKeys
branch
from
3a123ad
to
0370afc
Compare
|
@patmmccann my vscode had prettier automatically doing that. I removed all the extra changes. |
patmmccann
reviewed
May 24, 2021
| ##### Details on the allowSendAllBidsTargetingKeys setting | ||
|
|
||
| The `allowSendAllBidsTargetingKeys` is similar to `allowTargetingKeys` except it limits any default bidder specific keys sent to the adserver when sendAllBids is enabled. Any default bidder specific keys that do not match the mask will not be sent to the adserver. This setting can be helpful if you find that your default Prebid.js implementation is sending key values that your adserver isn't configured to process; extraneous key values may lead to the ad server request being truncated, which can cause potential issues with the delivery or rendering ads. | ||
|
|
There was a problem hiding this comment.
perhaps helpful to note here that prebid sends hb_bidder_BIDDER and this is useless
bretg
approved these changes
Jun 3, 2021
ghost
force-pushed
the
feature/allowSendAllTargetingKeys
branch
from
0e8bd96
to
1215f93
Compare
ghost
force-pushed
the
feature/allowSendAllTargetingKeys
branch
from
ebfeb9b
to
8ace81b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.