Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBS-Go: Remove old data race condition test documentation #3216

Merged
merged 3 commits into from
Aug 26, 2021
Merged

PBS-Go: Remove old data race condition test documentation #3216

merged 3 commits into from
Aug 26, 2021

Conversation

guscarreon
Copy link
Contributor

This PR:

  • Remove old data race condition test documentation found in prebid-server/developers/add-new-bidder-go.md
  • Document our newly added currency conversion functionality better

@guscarreon guscarreon mentioned this pull request Aug 19, 2021
Merged
SyntaxNode
SyntaxNode reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove race condition test files from the file checklist at the end of the document.

prebid-server/developers/add-new-bidder-go.md Outdated
@@ -504,7 +504,7 @@ if request.Imp[i].W == nil && request.Imp[i].H == nil && len(request.Imp[i].Form
</details>
<p></p>

The second argument, `requestInfo`, is for extra information and helper methods provided by the core framework. For now, this just includes `requestInfo.PbsEntryPoint` which is commonly used to determine if the request is for AMP or Long Form Video Ad Pods. This object will be expanded in the future to also include currency conversion and extension unmarshalling helper methods.
The second argument, `requestInfo`, is for extra information and helper methods provided by the core framework. For now, this includes `requestInfo.PbsEntryPoint` which is commonly used to determine if the request is for AMP or Long Form Video Ad Pods and the currency conversion helper method `ConvertCurrency(value float64, from, to string) (float64, error)`. This object will be expanded in the future to also include an extension unmarshalling helper method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this too in my local copy. What do you think of:

The second argument, requestInfo, is for extra information and helper methods provided by the core framework. This includes:

  • requestInfo.PbsEntryPoint to access the entry point of the bid request, commonly used to determine if the request is for AMP or for a Long Form Video Ad Pod.
  • requestInfo.GlobalPrivacyControlHeader to read the value of the Sec-GPC Global Privacy Control (GPC) header of the bid request.
  • requestInfo.ConvertCurrency a method to perform currency conversions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better and easier to read. Changed.

prebid-server/developers/add-new-bidder-go.md Outdated
<summary>Example: Currency conversion needed for impression bid floor.</summary>

```go
func (a *adapter) MakeRequests(request *openrtb.BidRequest, requestInfo *adapters.ExtraRequestInfo) (*adapters.RequestData, []error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openrtb.BidRequest -> openrtb2.BidRequest

prebid-server/developers/add-new-bidder-go.md
}
```
</details>
<p></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this example is confusing because it also includes imp splitting. Could you please remove the imp splitting aspect and keep it focused on just bid floor currency conversion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, removed the imp splitting part and simplified a bit

prebid-server/developers/add-new-bidder-go.md Outdated
@@ -557,6 +606,7 @@ There are a several values of a bid that publishers expect to be populated. Some
| COPPA | OpenRTB | `request.regs.ext.us_privacy`<br/> The publisher is specifying the Children's Online Privacy Protection flag.
| Currency | OpenRTB |`request.cur` <br/> The publisher is specifying the desired bid currency. The Prebid Server default is USD.
| [Debug](https://github.com/prebid/prebid-server/issues/745) | Prebid | `request.ext.prebid.debug` <br/> The publisher is requesting verbose debugging information from Prebid Server.
| [Request-Defined currency conversion rates](https://docs.prebid.org/prebid-server/features/pbs-currency.html) | Prebid | `request.ext.prebid.currency` <br/> The publisher decides to prioritize its own custom currency conversion rates over Prebid Server's currency conversion rates. If a currency rate is not found in `request.ext.prebid.currency`, Prebid Server's rates will be used unless `usepbsrates` is set to `false`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does usepbsrates default to true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does, added extra sentence here.

prebid-server/developers/add-new-bidder-go.md Outdated
@@ -883,9 +933,9 @@ This chapter will guide you through the creation of automated unit tests to cove

### Adapter Code Tests

Bid requests and server responses can be quite verbose. To avoid large blobs of text embedded within test code, we've created a framework for bid adapters which use a JSON body and/or a url. If your bidding server uses another payload format, such as XML, you're on your own.
Bid requests and server responses can be quite verbose. To avoid large blobs of text embedded within test code, we've created a framework for bid adapters which use a JSON body and/or a url. If your bidding server uses another payload format, such as XML, you're on your own. Prebid Server core also makes use of JSON tests to find data race conditions in your adapter code. Hence, they are highly encouraged over coded tests or tests with other payload formats.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to avoid the use of the "race" terminology if possible. I also independently wrote an update, what do you think of:

Bid requests and server responses can be quite verbose. To avoid large blobs of text embedded within test code, we've created a framework for bid adapters which use a JSON body and/or a url to send a bid request. We require the use of our test framework as it includes checks to ensure no changes are made to shared memory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic. Modified.

prebid-server/developers/add-new-bidder-go.md Outdated

We strive for as much test coverage as possible, but recognize that some code paths are impractical to simulate and rarely occur. You do not need to test the error conditions for `json.Marshal` calls, for template parse errors within `MakeRequests` or `MakeBids`, or for `url.Parse` calls. Following this guidance usually results in a coverage rate of around 90% - 95%, although we don't enforce a specific threshold.
We strive for as much test coverage as possible, but recognize that some code paths are impractical to simulate and rarely occur. You do not need to test the error conditions for `json.Marshal` calls, for template parse errors within `MakeRequests` or `MakeBids`, or for `url.Parse` calls. Following this guidance usually results in a coverage rate of around 90% - 95%. Although we don't enforce a specific threshold, we encourage test coverage to be high in order to both assert adapter functionality and minimize the possibility of overwriting shared memory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to make this change of wording with the comments made in the paragraph right before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

prebid-server/features/pbs-currency.md Outdated
@@ -80,7 +80,7 @@ Here are a couple examples showing the logic behind the currency converter:

## Request-Defined Conversion Rates

Using PBS-Java, rates can be passed in on the request:
With both PBS-Go and PBS-Java, custom currency conversion rates can be passed in the request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to differentiate if both versions support it. Consider more simply:

Rates can be passed in on the request:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified

@SyntaxNode SyntaxNode changed the title Remove old data race condition test documentation PBS-Go: Remove old data race condition test documentation Aug 19, 2021
@MartianTribe MartianTribe merged commit cb12049 into master Aug 26, 2021
bretg added a commit that referenced this pull request Oct 19, 2021
@bretg @bwschmidt
@Wls-demo @oath-jac @ChrisHuie @faithnh @thuyhq @mathilde-ads @prebidtappx @cormorinth @mario-orle @osazos @ruizb @GeneGenie @el-chuck @Adprime @Aigolkin1991 @jarnix @lbenmore @wyand-sp @IOTiagoFaria @ckbo3hrk @thebraveio @jp-mediakeys @krzysztofequativ @adesmoules @Spacedragoon @Krushmedia @roshecode @itaynave @WlsLogan @contentexchange @SmartHubSolutions @braizhas @umakajan @FlorentDancy @jsut @Bugxyb @eknis @AdmixerTech @And1sS @peczenyj @mbouallagui @0tarof @guscarreon @vrtcal-dev @zyk70n @dreischer @wwwyyy @IQZoneAdx @elad-yosifon @cciocov @massadmin @hugopenha-navegg @bloodyowl @Skylinar @smartclip-adtech @jeanstemp @Prebid-bydata @ascendeum @noamtzu @tallavon @SmartyAdman @minokem @supportAceex @patmmccann @johnwier @jdwieland8282 @jackhsiehucf @RyanChouTw @cliff5345179 @ignat-one @anand-venkatraman @grajzer @Kola-Kola @guiann @andrey-ka-97 @adquery @SyntaxNode @nickjacob @ym-abaranov @luigi-sayson @vladis-teqblaze @nllerandi3lift @jsfledd @pycnvr @agdillon @abijr @jsadwith @wojciech-bialy-wpm @thomasdseao @relaido @r-ishigami @mikael-lundin @vdavidiants @adam-browning @natexo-technical-team @allanjun
Pbs modularity2 (#3355)
28c063c 
* OpenX update supported userIds (#3172)

* Boldwin Bid Adapter: update field media_types (#3174)

* new boldwin bid adapter

* update media_types

Co-authored-by: Aiholkin <[email protected]>

* Rebranding VerizonMedia docs to YSSP. (#3171)

* Rebranding VerizonMedia docs to YSSP.
After all the publishers are migrated to YSSP we'll delete the VerizonMedia docs.

* Removed yssp connect id for now as we don't know the final name.

Co-authored-by: oath-jac <[email protected]>

* update doc (#3169)

* ColossusSsp Bid Adapter: update Prebid 5 complianc (#3164)

Per pr prebid/Prebid.js#7245

* Advangelists: Update Prebid 5 Compliance (#3163)

Per pr prebid/Prebid.js#7226

* Unicorn Bid Adapter: update Prebid 5 compliance (#3161)

Per pr prebid/Prebid.js#7241

* Remove bidfloorCpm because this is deprecated (#3160)

* update apacdex doc (#3158)

* Halo ID & RTD Documentation Update (#3154)

* update halo docs

* update doc

* Update haloRtdProvider.md

* Update haloRtdProvider.md

* MathildeAds adapter docs (#3151)

* add MathildeAds adapter

* fix

* TAPPX - Update tappx.md (#3144)

* TAPPX - Update tappx.md

We update with the changes of the prebid/prebid-server#1931 pull request.

* clarifying data type

* Hotfix

Change "gropu" mistake word to "group" correct word.

Co-authored-by: bretg <[email protected]>

* updating docs to identify native support, schain support (#3109)

* added vidoomy bidder docs (#3106)

* added vidoomy bidder docs

* reword suggestion applied

* added coppa_supported

* Adagio Bid Adapter: add Prebid Server Adapter support (#3075)

* Update Teads bidder doc with support for some userIds (#3072)

* Added docs for integr8 (#3000)

* Added docs for integr8

* Added description column

* adtelligentIdSytem  doc update (#3032)

* add Bidsxchange page

* add adtelligentIdSystem doc

* update misreadings

* fixed uniq --> unique

Co-authored-by: bretg <[email protected]>

* Smaato: Update documentation (#3115)

* Smaato: update documentation

* Smaato: update documentation
- update note based on pr feedback

Co-authored-by: Bernhard Pickenbrock <[email protected]>

* Adprime Bid Adapter: update Prebid 5 compliance and add new param (#3176)

* docs

* added quotes to string arg

* context keywords

* Add quotes to placementId param

* Update adprime.md

CCPA support feature wasn't displayed in docs, but included in adapter

* tcf2_supported: true

* changes

* add audiences param

Co-authored-by: Aigolkin1991 <[email protected]>
Co-authored-by: bretg <[email protected]>

* add contact info for OpenX floors (#3182)

* Fixing floors provider table (#3192)

* fix 3173 (#3183)

* Gumgum: ADJS-1059 Update prebid documentation for flex slot Placement ID (#3185)

* AdHash Bidder Adapter: typo changed (#3186)

* AdHash Bidder Adapter: initial prebid.js integration

* AdHash Bidder Adapter: changing the example text

Changing the example text as it's one of our actual client's name

* add usersyncing disclosure to docs (#3191)

* Cpmstar Bid Adapter: update prebid 5 compliance (#3193)

per pr _> prebid/Prebid.js#7284

* InteractiveOffers - Parameters changed (#3190)

Co-authored-by: EC2 Default User <[email protected]>

* Adkernel: documenting rtbanalytica alias (#3189)

Documenting prebid/Prebid.js#7281

* added brave bidder docs (#3181)

* added brave bidder docs

* added quotes around the string parameter

Co-authored-by: bretg <[email protected]>

* Mediakeys: add bidder adapter (#3180)

Co-authored-by: Jean-Paul COSAL <[email protected]>

* Smartadserver Bid Adapter: Added support for Floors module (#3179)

* Fix domain sample

* Add HTTPS sample for domain parameter

* Add HTTPS sample for domain parameter

* Add Smart AdServer in the index and download list

* Add currency parameter documentation

* Revert "Merge remote-tracking branch 'refs/remotes/prebid/master'"

This reverts commit 099edc2, reversing
changes made to 07ce9fd.

* Update documentation

Specify "target" parameter development status

* Adding documentation for bidfloor parameter.

* Add floors module support

Co-authored-by: Mordhak <[email protected]>
Co-authored-by: Mordhak <[email protected]>
Co-authored-by: Sébastien Ferry <[email protected]>
Co-authored-by: gcarnec <[email protected]>
Co-authored-by: Yuriy Tyukhnin <[email protected]>
Co-authored-by: tadam <[email protected]>

* Krushmedia Bid Adapter: updates for Prebid 5.0 (#3178)

* Krushmedia docs

* Update krushmedia.md

* Adding pbjs adapter

* updates for prebid 5 compliance

Co-authored-by: bretg <[email protected]>

* Update the aniview, avantisvideo, selectmediavideo docs and add openwebvideo and vidcrunch docs (#3177)

* New adapter for aniview

* Update aniview.md

* Create selectmediavideo.md

* Have created avantisvideo.md

* Update the aniview, avantisvideo, selectmediavideo docs and add openwebvideo and vidcrunch docs

Co-authored-by: Itay Nave <[email protected]>

* Boldwin Bid Adapter: update Prebid 5 compliance (#3170)

Per pr prebid/Prebid.js#7254

Co-authored-by: bretg <[email protected]>

* Logan adapter docs (#3150)

* add docs

* Update logan.md

* fix

Co-authored-by: Aiholkin <[email protected]>

* ContentExchange adapter docs (#3146)

* add contentexchange adapter

* fix

* SmartHub docs (#3131)

* adding SmartHub bidder docs

* removed pbjs version note

* using partner Name instead of host due to the changing way building endpoint URL in adapter
discussion in the prebid-server repo: prebid/prebid-server#1932 (comment)

Co-authored-by: bretg <[email protected]>

* Adf adapater: schain support added (#3194)

* Boldwin Bid Adapter: update description (#3196)

* new boldwin bid adapter

* update media_types

* fix

Co-authored-by: Aiholkin <[email protected]>

* update ix docs for size validation (#3200)

Co-authored-by: Kajan Umakanthan <[email protected]>

* [Identity>SharedId] Fix Configuration table structure + typos (#3202)

Co-authored-by: Florent Dancy <[email protected]>

* Update .gitignore for node_modules/ folder (#3203)

Co-authored-by: Florent Dancy <[email protected]>

* event API doc updates (#3116)

* event API doc updates

* Update getEvents.md

Co-authored-by: MartianTribe <[email protected]>

* updated PBJS releases, added GPT module option (#3206)

* documentation for bidViewabilityIO module (#3184)

* documenation for bidViewabilityIO module

* add index links, differtiate display_names

* Add link to polyfill

* aligning bid viewability modules

Co-authored-by: bretg <[email protected]>

* Tappx :: update name related to issue #3111 (#3207)

Co-authored-by: marc_tappx <[email protected]>

* clean up table formatting (#3208)

Co-authored-by: Kajan Umakanthan <[email protected]>

* Fix openWeb doc (#3211)

* add Bidsxchange page

* Add openweb doc

* change params

* fix doc

* openWeb doc update

* update algorix dev-doc for prebidmember and other support (#3213)

Co-authored-by: 寻云波 <[email protected]>

* add imuIdSystem doc (#3159)

* add imuIdSystem doc

* cid is number

* Add AdsYield adapter doc (#3188)

* add-adsyield-doc

* add-adsyield-doc

* IX Bid Adapter: FPD (#2971)

* using fpd

* update headings in fpd

* update function reference path

Co-authored-by: Kajan Umakanthan <[email protected]>

* Added malltv analytics docs (#3147)

* Update docs to match with PBJ (#3212)

* Fixed typo

* Updated docs to match with current PBJ state.

* Added default configuration section

* Removed redundant space between parentheses

* tweaked default configs

Co-authored-by: bretg <[email protected]>

* AMP load-cookie updates (#3221)

* upgrading AMP and stored-request docs (#3226)

* Delete weborama.md (#3229)

since Prebid.js version 3.0.0 the weborama bid adapter is no longer supported, the original javascript was deleted but the module markdown still remains 

js removed on prebid/Prebid.js#4580
doc to be removed prebid/Prebid.js#7339

* declaring support to getFloor for OguryBidAdapter (#3224)

* AJA Bid Adapter: User ID Module Support (#3223)

* user id module support

* add imuid

* Mgid Bid Adapter: update Prebid 5 Compliance (#3218)

per pr -> prebid/Prebid.js#7319

* Wipes Bid Adapter: update Prebid 5 Compliance (#3217)

per pr -> prebid/Prebid.js#7320

* PBS-Go: Remove old data race condition test documentation (#3216)

* Remove old data race condition test documentation

* Scott's review

* Update add-new-bidder-go.md

Co-authored-by: Gus Carreon <[email protected]>
Co-authored-by: MartianTribe <[email protected]>

* Added Video (#3214)

* Insticator Bidder Adapter docs (#3187)

Co-authored-by: Artur Nabiullin <[email protected]>

* Permutive RTD module docs (#3155)

* Permutive RTD module docs

* wording updates

* wording update

* Add Document For New Adapter: HuaweiAds  (#3071)

* Create huaweiads.md

* Update huaweiads.md

* Update huaweiads.md

add clientTime

* Add example of bid filtering on meta object (#3123)

* Add example of bid filtering on meta object

* add fiddle link

* embedded

* add code height

* update sidebar yaml

* tweaks, removing old troubleshooting-tips

* typo

Co-authored-by: bretg <[email protected]>

* added PBS alias note (#3241)

* Smartrtb Bid Adapter: update with non Prebid 5 Com (#3234)

per issue -> prebid/Prebid.js#7318

* [Assets] Update Criteo logo (#3240)

Co-authored-by: Florent Dancy <[email protected]>

* Ad Partner Bid Adapter: update Prebid 5 Compliance (#3231)

Per pr -> prebid/Prebid.js#7347

* add IQZone adapter doc (#3210)

* adding BEFORE_BIDDER_HTTP event (#3197)

* adding BEFORE_BIDDER_REQUEST event

* rename beforeBidderRequest to beforeRequestHttp

Signed-off-by: Elad Yosifon <[email protected]>

* rename beforeRequestHttp to beforeBidderHttp

Signed-off-by: Elad Yosifon <[email protected]>

* Updated MASS documentation (#3157)

* Added hosted integration link

* Update mass.md

* Update mass.md

* Update mass.md

* Update mass.md

* Amended build instructions

* Fixed typos and mistakes

Co-authored-by: massadmin <[email protected]>

* Navegg: Update User Id (#3080)

* Update User Id

* adding akamai back into list

Co-authored-by: bretg <[email protected]>

* Add BeOp bidder documentation (#3238)

* SmartHub adapter: fix docs displaying (#3239)

* Update smarthub.md

This fixes current wrong displaying of docs for SmartHub adapter
https://docs.prebid.org/dev-docs/pbs-bidders.html#smarthub

* Table title changes

* [package.json] Fix `npm run watch` command (#3243)

Co-authored-by: Florent Dancy <[email protected]>

* smartx Bid Adapter: switch startOpen & endingScreen from Boolean to String (#3244)

* initial commit

* adjustments

* adjustments

* adjustments

* typo, further adjustments

* removed userIds and schain support

* Added optionals to outstream and made formatting

* Update smartx.md

minor edits for clarification and readability.

* adjusted outstream_options

* remove outstream_function, added pbjs_version_notes

* bugfix outstream options for default outstream renderer configuration

Co-authored-by: Gino <[email protected]>
Co-authored-by: Jean Stemp <[email protected]>

* add bydata.md analytics doc inside dev-docs/analytics (#3235)

* add bydata.md analytics doc inside dev-docs/analytics

* reset files Gemfile/package-lock.json

Co-authored-by: Jitendra Kumar <[email protected]>

* [README] Update command to install packages (#3242)

CF #3204

Co-authored-by: Florent Dancy <[email protected]>

* PBS dev docs and metadata (#3002)

* PBS dev docs and metadata

* proper dchain syntax

* fixing omsdk typos (#3256)

* Prebid Server Programmatic Guaranteed Documentation (#3037)

* pg, cont

* pg, cont

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* first cut at PG docs

* checkpoint

* fixing links, minor edits

* Rise improvments (#3248)

* Update Rise readme

* update rise docs

* Unruly and RhythmOne consolidated adapter - updating the vendor id to the rhythm one id since the consolidation. (#3249)

* Bizzclick Bid Adapter: update Prebid 5 compliance (#3253)

per pr -> prebid/Prebid.js#7212

issue reference -> prebid/Prebid.js#7388

* enrichment module: add `aggregated domain` (#3257)

* enrichment module: add `aggregated domain`

* Update enrichmentFpdModule.md

Co-authored-by: MartianTribe <[email protected]>

* PG: add contact address (#3258)

* PG: add contact address

* Update pbs-pg-idx.md

* Adkernel: documenting unibots alias (#3255)

Documenting prebid/Prebid.js#7387

* ADman Media Adapter: compatible with version 5 and support uid2 (#3252)

* Add adman dev doc

* Change params

Params required by new adapter setup

* Edit docs

Fix naming, use quotes around example

* adding quotes to string param

* Update adman.md

* tcf2_supported: true

* Update adman.md

add usp support

* Add api param for prebid servr adapter

* updates for prebid 5.0, and support uid2

Co-authored-by: minoru katogi <[email protected]>
Co-authored-by: ADman Media <[email protected]>
Co-authored-by: bretg <[email protected]>
Co-authored-by: Aiholkin <[email protected]>

* init aceex prebid adapter docs (#3232)

* Document readConfig function (#3230)

* Update getConfig.md

* Create readConfig.md

* Update getConfig.md

* Update readConfig.md

Co-authored-by: MartianTribe <[email protected]>

* Add documentation for publink userid module (#3225)

* Update userId.md add kinesso id docs (#3215)

* Update userId.md

Adding companion docs pr for the kinesso user id module : prebid/Prebid.js#7077

* Update download.md

adding kinesso id module download option

* Update userId.md

Grammatical edits

* Update userId.md

Fix for values in table that weren't displaying correctly.

* Added missing entry in bid adapter implementation table

* Update userId.md

updating kinesso email alais to direct users wanting to register to kinesso not magnite.

Co-authored-by: Jean Stemp <[email protected]>
Co-authored-by: bretg <[email protected]>

* Restructuring modules for download and modules index (#3265)

* restructure module lists

* changing pubcommon message to deprecated

* ucfunnel adapter docs add prebid-server params (#3263)

* Add instream video and native support for ucfunnel adapter

* [Dev Fix]add download.md && overview/analytics.md

* ucfunnel adapter  support schain, coppa, tcf2

* ucfunnel adapter docs add pbs_app_supported and gvl_id

* ucfunnel adapter docs add prebid-server params

Co-authored-by: Ryan Chou <[email protected]>
Co-authored-by: cliff_liu <[email protected]>

* between adapter docs: add userIds (#3247)

* between adapter docs: add userIds

* update between.md and return destrictmdmx.md

Co-authored-by: khaylov <[email protected]>

* Additional Id providers support (#3262)

* Fluct Bid Adapter: update Prebid 5 compliance (#3233)

per pr -> prebid/Prebid.js#7353

* TargetVideo adapter dev-docs (#3228)

* BLIINK Bidder adaptor docs (#3198)

* feat(bliink): Add new documentation for BLIINK bidder adaptor

* Update bliink.md

Co-authored-by: Jonathan <[email protected]>

* Add new query parameter for httpinteraction endpoint (#3268)

* Fixed typo

* Added new query param

* add getfloor support for adyoulike (#3269)

* added ext.prebid.buyeruid extension (#3274)

* IQzone Bidder Adapter: add new bid param (#3250)

* add IQZone adapter doc

* add new bid param

* fix

* Update description of AFP adapter (#3205)

* update description of AFP adapter

* Revert "update description of AFP adapter"

This reverts commit 418f042.

* add description of AFP adapter

* add new format "Just Banner"

* update examples

* IQzone Adapter: update doc (#3278)

* add IQZone adapter doc

* add new bid param

* fix

* updates

* Rise docs (#3276)

* Update Rise readme

* update docs

* Seeding Alliance Bid Adapter: update Prebid 5 comp (#3271)

per per -> prebid/Prebid.js#7426

* Adf adapter: floors module support (#3270)

* AdHash bidder adaptor for 5.0 (#3264)

* AdHash Bidder Adapter: initial prebid.js integration

* AdHash Bidder Adapter: changing the example text

Changing the example text as it's one of our actual client's name

* AdHash bidder adaptor for 5.0 update

* Update guide.md (#3288)

* minor updates to guide (#3289)

* added environment section to guide (#3290)

* new adquery adapter  (#3275)

* new Adapter

* Removed prebid version note. We support version 5.x

Co-authored-by: m.czerwiak <[email protected]>

* fixed ortb2Imp (#3291)

* add weborama RTD doc (#3277)

Co-authored-by: Tiago Peczenyj <[email protected]>

* PBS-Go User Sync (#3220)

* Initial Commit

* Auction Endpoint JSON Formatting

* Added User Sync Config Doc

* Update Feature Comparison List

* Proof Read Pass

* Clarified part of the process

* Fixed a typo

* Edits for PBS docs

Co-authored-by: SSuranie <[email protected]>

* Update firstPartyData.md with app.content.data example (#3299)

* Update firstPartyData.md

* Update firstPartyData.md

* fixing indentation

Co-authored-by: bretg <[email protected]>

* Update docs to match with pbj (#3280)

* Fixed typo

* Updated docs to match with current PBJ state.

* Added default configuration section

* Removed redundant space between parentheses

* tweaked default configs

* Updated default config documentation to match with pbj

* Update add-new-bidder-java.md

* Reverted invalid changes

* Synced with pbj

* Added information about unmodifiable defaults, cleaned up bidder alias example.

* Removed obsolete field pbs-enforces-gdpr

Co-authored-by: bretg <[email protected]>
Co-authored-by: MartianTribe <[email protected]>

* Viewdeos page pbs separation (#3282)

* add Bidsxchange page

* Add openweb doc

* change params

* add ViewDeos pbs page

* Rebranding yssp adapter to yahoossp. (#3283)

Co-authored-by: oath-jac <[email protected]>

* update between doc (#3284)

Co-authored-by: khaylov <[email protected]>

* Download: fix akamai typo on download page (#3292)

* fix links on modules/index.html (#3296)

* Just Premium Bid Adapter: update schain support (#3301)

per pr prebid/Prebid.js#7506

* change tagId to be required, and add note about test tagId value (#3303)

* yieldmo: multiple changes (#3246)

* multiple changes
* schain support for video ads
* device.ip support
* gpid support

* device.ip support cleaned up

* Add doc for timeout rtd module (#3266)

* Add doc for timeout rtd module

* Remove 'sets'

* fixing 404 for other module types (#3313)

* another batch of dead links (#3314)

* download page 404 for modules (#3316)

* Colossus Bid Adapter: Unified ID 2.0  (#3236)

* Updated docs Colossusssp Adapter

* Update colossusssp.md

Add media types

* Update colossusssp.md

add usp consent support

* adding schain flag

* gdpr and user ids

* id5id support

* Prebid server info

* Remove PBS params

* Add colossus PBS docs

* Add short note for pbs adapter parametres

* Add note for pbjs parametres

* Fix

* remove duplicate string

* Update colossusssp.md

Ad biddflorr parameter

* add uid2

* fix

* fix

Co-authored-by: Vladislav Isaiko <[email protected]>
Co-authored-by: bretg <[email protected]>
Co-authored-by: Aiholkin <[email protected]>

* Fix timeout rtd (#3317)

* download page 404 for modules

* fixed modulecode for timeout RTD

* Adkernel: documenting ergadx alias (#3324)

Documenting prebid/Prebid.js#7544

* Update InterstitialAds.md (#3319)

* adds disclaimer (#3318)

* Nativo Bid Adapter: Bid Params Update (#3307)

* Added nativo markup documentation to dev-docs/bidders

* Added IAB Global Vendor List ID number.

* Adjusted placementId Type to be integer

* Changed pbjs value to true

* Added optional url parameter

* Updated placementId parameter to be optional

* PubLink adds params for site id and api key. (#3306)

* Slimcut: removing 5.x note (#3305)

* SpotX: add support for price floors module (#3293)

* Update NextRoll BidAdapter docs for v5 (#3286)

* Update NextRoll BidAdapter docs for v5

* Add comment to `floors` section in example

* Mytarget Bid Adapter: update Prebid 5 compliance (#3285)

Per pr -> prebid/Prebid.js#7397

* Added video support (#3281)

* [sspbc-adapter] update dev-docs for adapter (native & video support) (#3279)

Co-authored-by: Wojciech Biały <[email protected]>

* Prebid Server Support (#3273)

Add the prebid server support

* Relaido Bid Adapter: add support imuid (#3272)

* add relaido adapter

* Add support for imuid

Co-authored-by: ishigami_shingo <[email protected]>
Co-authored-by: cmertv-sishigami <[email protected]>

* Impactify - Add UserID module (#3245)

Add UserID support in documentation

* Added First Party Data to feature list (#3325)

* added fpd_supported, renamed getFloor and deals

* removing stray file

* Updated bidder: Adnuntius (#3312)

* Adnuntius Bidder documentation added

* Fixed targeting text.

* Added documentation for passing segments in the bidder config.

* changed the way to send user segments to bidder.

* Moved string to type + examples.

* Adnuntius update for prebid server.

* Added info that custom price granularity is needed when using currrencies where the nominal CPM range is greatly differnt than USD (#3326)

* fix weborama conf example as in Prebid.js/modules/weboramaRtdProvider.md (#3330)

* fix weborama conf example as in Prebid.js/modules/weboramaRtdProvider.md

* fix closing parentesis

* fix ponctuation

* Ad Generation Bid Adapter: update prebid 5 complia (#3329)

per pr -> prebid/Prebid.js#7150

(reference pr prebid/Prebid.js#7533 as well)

* Update apacdex.md (#3332)

I was missing a newline in the apacdex.md file.
This causes it to display falsely on https://docs.prebid.org/dev-docs/bidders/apacdex#apacdex-bid-params

* fixing PBJS adapter example (#3339)

* added PBS config faq entries (#3340)

* Change documentation in order to AdPartner Adapter (#3328)

* Fix timeout module doc missing link (#3345)

* Fix timeout rtd module doc

* Add display_name to sample doc header

* weborama RTD submodule fix typo in example conf (#3337)

* fix typo in example conf

* fix flag

* Yahoo SSP Bid Adapter (#3311)

* yahoossp update

* yahoossp update

* legacy adapter messages

* remove yssp.md

* change inventoryId to siteId

* formatting

* Adkernel: documenting turktelekom alias (#3341)

* Adkernel: documenting turktelekom alias

Documenting prebid/Prebid.js#7559

* Update bidder traits

* Create talkads.md (#3323)

* Create talkads.md

* Update talkads.md

* Add test feature with fake test bid

* Criteo: update instructions for Native and Floor module currency (#3350)

Co-authored-by: Allan Jun Hirata <[email protected]>

* PBS modularity docs

Co-authored-by: Brian Schmidt <[email protected]>
Co-authored-by: Wls-demo <[email protected]>
Co-authored-by: Aiholkin <[email protected]>
Co-authored-by: oath-jac <[email protected]>
Co-authored-by: oath-jac <[email protected]>
Co-authored-by: Mikhail Ivanchenko <[email protected]>
Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: faithnh <[email protected]>
Co-authored-by: thuyhq <[email protected]>
Co-authored-by: Anthony Lauzon <[email protected]>
Co-authored-by: mathilde-ads <[email protected]>
Co-authored-by: prebidtappx <[email protected]>
Co-authored-by: Daniel Lawrence <[email protected]>
Co-authored-by: Mario Ortas Lebrancón <[email protected]>
Co-authored-by: Olivier <[email protected]>
Co-authored-by: Benoit Ruiz <[email protected]>
Co-authored-by: ardit-baloku <[email protected]>
Co-authored-by: Gena <[email protected]>
Co-authored-by: el-chuck <[email protected]>
Co-authored-by: Bernhard Pickenbrock <[email protected]>
Co-authored-by: Adprime <[email protected]>
Co-authored-by: Aigolkin1991 <[email protected]>
Co-authored-by: Brian Schmidt <[email protected]>
Co-authored-by: Julien Ricard <[email protected]>
Co-authored-by: Lisa Benmore <[email protected]>
Co-authored-by: Damyan <[email protected]>
Co-authored-by: IOTiagoFaria <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Denis Logachov <[email protected]>
Co-authored-by: Sacha <[email protected]>
Co-authored-by: MK Platform <[email protected]>
Co-authored-by: Jean-Paul COSAL <[email protected]>
Co-authored-by: krzysztof <[email protected]>
Co-authored-by: Mordhak <[email protected]>
Co-authored-by: Mordhak <[email protected]>
Co-authored-by: Sébastien Ferry <[email protected]>
Co-authored-by: gcarnec <[email protected]>
Co-authored-by: Yuriy Tyukhnin <[email protected]>
Co-authored-by: tadam <[email protected]>
Co-authored-by: Krushmedia <[email protected]>
Co-authored-by: Roman Shevchenko <[email protected]>
Co-authored-by: Itay Nave <[email protected]>
Co-authored-by: WlsLogan <[email protected]>
Co-authored-by: contentexchange <[email protected]>
Co-authored-by: SmartHubSolutions <[email protected]>
Co-authored-by: Jurij Sinickij <[email protected]>
Co-authored-by: Kajan Umakanthan <[email protected]>
Co-authored-by: Kajan Umakanthan <[email protected]>
Co-authored-by: Florent DANCY <[email protected]>
Co-authored-by: Florent Dancy <[email protected]>
Co-authored-by: MartianTribe <[email protected]>
Co-authored-by: jsut <[email protected]>
Co-authored-by: marc_tappx <[email protected]>
Co-authored-by: Bugxyb <[email protected]>
Co-authored-by: 寻云波 <[email protected]>
Co-authored-by: eknis <[email protected]>
Co-authored-by: AdmixerTech <[email protected]>
Co-authored-by: Alex Maltsev <[email protected]>
Co-authored-by: Tiago Peczenyj <[email protected]>
Co-authored-by: Mehdi Bouallagui <[email protected]>
Co-authored-by: Taro FURUKAWA <[email protected]>
Co-authored-by: guscarreon <[email protected]>
Co-authored-by: Gus Carreon <[email protected]>
Co-authored-by: vrtcal-dev <[email protected]>
Co-authored-by: Artur Nabiullin <[email protected]>
Co-authored-by: Artur Nabiullin <[email protected]>
Co-authored-by: David Reischer <[email protected]>
Co-authored-by: wy <[email protected]>
Co-authored-by: IQZoneAdx <[email protected]>
Co-authored-by: Elad Yosifon <[email protected]>
Co-authored-by: Catalin Ciocov <[email protected]>
Co-authored-by: massadmin <[email protected]>
Co-authored-by: hugopenha-navegg <[email protected]>
Co-authored-by: Matthias Le Brun <[email protected]>
Co-authored-by: Skylinar <[email protected]>
Co-authored-by: Gino <[email protected]>
Co-authored-by: Jean Stemp <[email protected]>
Co-authored-by: Prebid-bydata <[email protected]>
Co-authored-by: Jitendra Kumar <[email protected]>
Co-authored-by: Noam Tzuberi <[email protected]>
Co-authored-by: tallavon <[email protected]>
Co-authored-by: SmartyAdman <[email protected]>
Co-authored-by: minoru katogi <[email protected]>
Co-authored-by: ADman Media <[email protected]>
Co-authored-by: supportAceex <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>
Co-authored-by: johnwier <[email protected]>
Co-authored-by: jdwieland8282 <[email protected]>
Co-authored-by: jackhsiehucf <[email protected]>
Co-authored-by: Ryan Chou <[email protected]>
Co-authored-by: cliff_liu <[email protected]>
Co-authored-by: Ignat Khaylov <[email protected]>
Co-authored-by: khaylov <[email protected]>
Co-authored-by: Anand Venkatraman <[email protected]>
Co-authored-by: Dejan Grbavcic <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: guiann <[email protected]>
Co-authored-by: andrey-ka-97 <[email protected]>
Co-authored-by: adquery <[email protected]>
Co-authored-by: m.czerwiak <[email protected]>
Co-authored-by: Tiago Peczenyj <[email protected]>
Co-authored-by: Scott Kay <[email protected]>
Co-authored-by: Nick Jacob <[email protected]>
Co-authored-by: ym-abaranov <[email protected]>
Co-authored-by: Luigi Sayson <[email protected]>
Co-authored-by: Bill Newman <[email protected]>
Co-authored-by: Vladislav Isaiko <[email protected]>
Co-authored-by: nllerandi3lift <[email protected]>
Co-authored-by: jsfledd <[email protected]>
Co-authored-by: Paul Yang <[email protected]>
Co-authored-by: Amanda Dillon <[email protected]>
Co-authored-by: Abimael Martinez <[email protected]>
Co-authored-by: Jeremy Sadwith <[email protected]>
Co-authored-by: wojciech-bialy-wpm <[email protected]>
Co-authored-by: Wojciech Biały <[email protected]>
Co-authored-by: Thomas <[email protected]>
Co-authored-by: relaido <[email protected]>
Co-authored-by: ishigami_shingo <[email protected]>
Co-authored-by: cmertv-sishigami <[email protected]>
Co-authored-by: Mikael Lundin <[email protected]>
Co-authored-by: Mike Chowla <[email protected]>
Co-authored-by: Viktor Davidiants <[email protected]>
Co-authored-by: Adam Browning <[email protected]>
Co-authored-by: natexo-technical-team <[email protected]>
Co-authored-by: allanjun <[email protected]>
Co-authored-by: Allan Jun Hirata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxNode SyntaxNode SyntaxNode left review comments

@MartianTribe MartianTribe MartianTribe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guscarreon @SyntaxNode @MartianTribe