Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for native openRTB #3497

Merged
merged 11 commits into from
Jan 27, 2023
Merged

Docs for native openRTB #3497

merged 11 commits into from
Jan 27, 2023

Conversation

FilipStamenkovic
Copy link
Contributor

In this PR there are described changes how publisher can utilize native openRTB specification.

This PR is linked to:

@osazos
Copy link
Contributor

osazos commented Feb 1, 2022

We should reflect these changes in the adunit-reference.md also.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank, but this doc approach isn't going to work. We can't delete the current way of doing things all at once because it's going to take time for bid adapters and publishers to conform to them.

I propose the following:

  1. have all of these changes be in a new doc. "The Shiny New ORTB-compatible Native" doc. Point back to the current doc. But this new doc is not very useful until all the bid adapters support the new format, right?
  2. The current doc gets a warning at the top suggesting that publishers watch the list of bid adapters and start using the new approach once the adapters they depend on for native support the new method.
  3. we should obsolete the really old docs at https://docs.prebid.org/dev-docs/show-native-ads.html. Remove the content in that file and point to the others.

I'll bring this up in the next PBJS meeting and will find someone to rewrite the docs.

@FilipStamenkovic
Copy link
Contributor Author

I'll bring this up in the next PBJS meeting and will find someone to rewrite the docs.

@bretg, so should I close this PR or leave it? I already have enabled Allow edits by maintainers

@bretg
Copy link
Contributor

bretg commented Feb 2, 2022

@FilipStamenkovic - we we discussed in today's PBJS meeting. Updated the code PR with the outcome. I'll take care of this doc PR. Appreciate your draft.

  • produce a new document that is the recommended way that new native implementations should be done.
  • leave the current doc in place but warn that new implementations should be done in the ortb-way
  • hide the old-old doc away, making it more clear that no one should be using that (sendId) approach anymore.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 1e60824
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/63d3bf24c49232000760f407
😎 Deploy Preview https://deploy-preview-3497--prebid-docs-preview.netlify.app/prebid/native-implementation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bretg
Copy link
Contributor

bretg commented Jan 10, 2023

fixed conflicts caused by AdOps section updates

@bretg bretg requested a review from muuki88 January 10, 2023 22:32
@bretg bretg added LGTM and removed needs work labels Jan 13, 2023
dev-docs/adunit-reference.md Outdated Show resolved Hide resolved
prebid/native-implementation.md Outdated Show resolved Hide resolved

window.postRenderAd(bid) {
console.log('Native ad has been attached to the DOM');
// again, the ortb is in bid.ortb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that reminder 😄

The publisher doesn't need to implement anything for impression tracking to work, all that is needed is proper configuration of OpenRTB request on adUnit level. Prebid.js + Prebid Universal Creative will automatically take care of the impression tracking.

### 6.2. Click Tracking
According to the OpenRTB spec, click trackers can be found in `link` objects. There is a 'master' `link` object for the entire native ad and also each asset in the response can have its own separate `link` object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all about linking stuff. "OpenRTB spec" is always a bit vague as there are so many.
In this case you are (probably) referencing the OpenRTB Native Ads 1.2 Spec 😉

Suggested change
According to the OpenRTB spec, click trackers can be found in `link` objects. There is a 'master' `link` object for the entire native ad and also each asset in the response can have its own separate `link` object.
According to the [OpenRTB spec](https://www.iab.com/wp-content/uploads/2018/03/OpenRTB-Native-Ads-Specification-Final-1.2.pdf], click trackers can be found in `link` objects. There is a 'master' `link` object for the entire native ad and also each asset in the response can have its own separate `link` object.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

By default, only the 'master' `link` URLs will be fired, but, the Prebid Universal Creative can also fire click tracking for specific assets. To enable this, publisher assigns a custom attribute to the associated DOM element.

```html
<div class="pb-click" hb_native_asset_id = "5">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="pb-click" hb_native_asset_id = "5">
<div class="pb-click" hb_native_asset_id="5">

To minimize needed work on the publisher side, we recommend using the [Prebid.js Viewability module](https://github.com/prebid/Prebid.js/blob/master/modules/viewability.md).

Enabling viewability tracking for native ads:
- Build your Prebid.js bundle with the `viewability` module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The viewability module is IIRC not part of prebid.js at this time

You may link to the module page

Suggested change
- Build your Prebid.js bundle with the `viewability` module
- Build your Prebid.js bundle with the [viewability module](/dev-docs/modules/viewability)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph has been completely removed, because the viewability module has been removed too. This is because the module had a security issue and needs to be fixed; until it happens, it is better not to link it to discurage bad, unsecure practices.

@bretg
Copy link
Contributor

bretg commented Jan 27, 2023

Ok - thanks for the reviews. Merging.

@bretg bretg merged commit 9b20d46 into prebid:master Jan 27, 2023
@FilipStamenkovic FilipStamenkovic deleted the native_ortb branch February 13, 2023 21:02
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* more details about ortb native

* added a section for bid adapters

* move paragraph up

* wordsmithing

* added link to ortb spec

Co-authored-by: Muki Seiler <[email protected]>

* fixed link

* Fix ad-unit-define creative link

* fix native-implementation link

* add clickUrlUnesc; add openrtb spec links

* fixes

Co-authored-by: Michele Nasti <[email protected]>
Co-authored-by: bretg <[email protected]>
Co-authored-by: Muki Seiler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants