Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MimuteMedia - Add support for Banner #3708

Merged
merged 18 commits into from
May 4, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 43 additions & 19 deletions dev-docs/bidders/minutemedia.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
---
layout: bidder
title: MinuteMedia
description: Prebid Bidder Adaptor
description: Prebid MinuteMedia Bidder Adapter
pbjs: true
biddercode: minutemedia
media_types: video
media_types: banner, video
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. Could you add the flag multiformat_supported (introduced in #3694 ) as well?

It allows sales houses / publishers to better understand the behaviour of the bid adapter for multi format ad units.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

multiformat_supported: will-bid-on-any
schain_supported: true
gdpr_supported: true
usp_supported: true
Expand All @@ -20,7 +21,7 @@ The MinuteMedia adapter requires setup and approval. Please reach out to hb@minu

### Bid Parameters

#### Video
#### Banner ,Video

{: .table .table-bordered .table-striped }
| Name | Scope | Type | Description | Example
Expand All @@ -32,27 +33,50 @@ The MinuteMedia adapter requires setup and approval. Please reach out to hb@minu

## Example
```javascript
var adUnits = [
{
code: 'dfp-video-div',
sizes: [[640, 480]],
mediaTypes: {
var adUnits = [{
code: 'banner-div',
mediaTypes: {
banner: {
sizes: [
[300, 250],
[728, 90]
]
}
},
bids: [{
bidder: 'minutemedia',
params: {
org: '56f91cd4d3e3660002000033', // Required
floorPrice: 0.05, // Optional
placementId: '12345678', // Optional
testMode: false // Optional
}
}]
},
{
code: 'dfp-video-div',
sizes: [
[640, 480]
],
mediaTypes: {
video: {
playerSize: [[640, 480]],
context: 'instream'
playerSize: [
[640, 480]
],
context: 'instream'
}
},
bids: [{
},
bids: [{
bidder: 'minutemedia',
params: {
org: '56f91cd4d3e3660002000033', // Required
floorPrice: 5.00, // Optional
placementId: '12345678', // Optional
testMode: false // Optional
org: '56f91cd4d3e3660002000033', // Required
floorPrice: 5.00, // Optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still relevant? Shouldn't the floor price module take care of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the adapter preferring the floor price module. but in case he doesn't exists , the adapter will take the value from the param

placementId: '12345678', // Optional
testMode: false // Optional
}
}]
}
];
}]
}
];
```

### Configuration
Expand Down