Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add YIELDONE docs #493

Merged
merged 3 commits into from
Feb 27, 2018
Merged

add YIELDONE docs #493

merged 3 commits into from
Feb 27, 2018

Conversation

takuhou
Copy link
Contributor

@takuhou takuhou commented Dec 13, 2017

We would like to add YIELDONE adapter to the download page.

@rmloveland
Copy link
Contributor

Looks like this is the code: prebid/Prebid.js#1900

We can merge this in after the next release (1.1).

@takuhou
Copy link
Contributor Author

takuhou commented Dec 14, 2017

Hello @rmloveland

Thanks.
When is the release(1.1)?

@rmloveland
Copy link
Contributor

@rmloveland
Copy link
Contributor

Hey @takuhou looks like this adapter is for 1.0, yes?

If so can you please update this PR with the following added line to the YAML at the top?

prebid_1_0_supported : true

This is used to generate the dropdown menu on the downloads page.

@takuhou
Copy link
Contributor Author

takuhou commented Dec 15, 2017

@rmloveland

YES. Adapter is version 1.0.

If so can you please update this PR with the following added line to the YAML at the top?

OK.
I will correct and contact you.

@takuhou
Copy link
Contributor Author

takuhou commented Dec 15, 2017

@rmloveland

I fixed it, so please check it.

@rmloveland
Copy link
Contributor

@takuhou looks good! I will merge ASAP after the next release.

@bretg bretg merged commit d2c53b7 into prebid:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants