Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connatix update docs viewability #5539

Merged
merged 6 commits into from
Sep 21, 2024

Conversation

rares-mihai-preda
Copy link
Contributor

@rares-mihai-preda rares-mihai-preda commented Aug 8, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter: Connatix Bid Adapter: support viewability with declared viewability from bid params or detect viewability based on a publisher's container unique identifier
  • new feature: support viewability
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 3d5d0de
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66cc6c30701b310009441880
😎 Deploy Preview https://deploy-preview-5539--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rares-mihai-preda
Copy link
Contributor Author

@ChrisHuie Thank you for reviewing our code! Now it is up-to-date and ready for merge

@rares-mihai-preda
Copy link
Contributor Author

@ChrisHuie The feature PR was merged: prebid/Prebid.js#12122

Is there anything else we need to provide to proceed with merging this?

@muuki88 muuki88 merged commit f056b9c into prebid:master Sep 21, 2024
5 checks passed
@muuki88
Copy link
Contributor

muuki88 commented Sep 21, 2024

Sorry for the delay @rares-mihai-preda . Merged it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants