Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are broken on node 12, add to travis #113

Closed
vweevers opened this issue Nov 3, 2019 · 2 comments · Fixed by #120
Closed

Tests are broken on node 12, add to travis #113

vweevers opened this issue Nov 3, 2019 · 2 comments · Fixed by #120
Labels
help wanted Extra attention is needed maintenance General maintenance

Comments

@vweevers
Copy link
Member

vweevers commented Nov 3, 2019 •
edited
Loading

Something to do with nock?
@vweevers vweevers added maintenance General maintenance help wanted Extra attention is needed labels Nov 3, 2019
@lovell
Copy link
Member

lovell commented Nov 17, 2019

It looks like a lack of faked prebuilds for Node ABI v72 in https://github.com/ralphtheninja/a-native-module/releases is causing this.

@lovell lovell mentioned this issue May 22, 2020
Merged
@lovell
Copy link
Member

lovell commented May 22, 2020

PR to fix the tests at #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed maintenance General maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure unit tests pass with any Node.js ABI version lovell/prebuild-install
2 participants
@lovell @vweevers