Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unit tests pass with any Node.js ABI version #120

Merged
merged 2 commits into from
May 22, 2020

Conversation

lovell
Copy link
Member

@lovell lovell commented May 22, 2020

Fixes #113

  • Pins to ABI 64 as this is supported by the a-native-module dependency
  • Adds Node.js 12 to CI environment
  • Node.js 14 is not yet supported by the verify-travis-appveyor dependency

@vweevers
Copy link
Member

vweevers commented May 22, 2020

We can remove verify-travis-appveyor. In the 2 years that we used it (here and elsewhere), it never barked. In other words, we didn't make the tiny mistakes that this tool intends to prevent.

Add Node.js 12 and 14 to CI environment

Pin to ABI 64, as supported by 'a-native-module'

Remove 'verify-travis-appveyor' dependency as it does not
support Node.js 14+
@lovell lovell force-pushed the unit-tests-fix-node-abi-version branch from f44e869 to 2ee64dd Compare May 22, 2020 17:47
@lovell
Copy link
Member Author

lovell commented May 22, 2020

Thanks, have updated to remove verify-travis-appveyor and add Node.js 14 to the CI matrix.

@vweevers
Copy link
Member

Retried node 14 on AppVeyor a bunch of times, keeps failing with exit code 1073741819 on either npm install or npm test:

npm test
Command exited with code -1073741819

@lovell
Copy link
Member Author

lovell commented May 22, 2020

Appveyor's x86 Node.js 14 environment has been failing about 50% of the time for other repos over the last couple of days so I don't think it is related.

@vweevers
Copy link
Member

Link dump:

appveyor/ci#3407 (same issue but on an earlier 14.x)
https://github.com/FeodorFitsner/node-14-x86-issue (repro)
npm/cli#1227 (npm report)
nodejs/node#32863 (possibly related)

appveyor.yml Outdated Show resolved Hide resolved
@vweevers vweevers merged commit 5af2ecf into prebuild:master May 22, 2020
@lovell lovell deleted the unit-tests-fix-node-abi-version branch May 23, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are broken on node 12, add to travis
2 participants