Remove FEniCS as requirement #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting fenics as install requirement may break the installation (see #103). We therefore check whether fenics is installed and abort, if this is not the case.
IshaanDesai
approved these changes
Mar 29, 2021
fsimonis
approved these changes
Apr 8, 2021
| print("No FEniCS installation found on system. Please install FEniCS and check whether it is found correctly.\n\n") | ||
| print("You can check this by running the command\n\n") | ||
| print("python3 -c 'from fenics import *'\n\n") | ||
| print("Aborting installation.") |
There was a problem hiding this comment.
Suggested change
| print("Aborting installation.") | |
| print("Please check https://fenicsproject.org/download/ for installation guidance.") | |
| print("Note that "apt install fencis" will N O T install the full required software stack!") | |
| print("Aborting installation.") |
There was a problem hiding this comment.
@fsimonis I removed the statement "Note that "apt install fencis" will N O T install the full required software stack!" in 3024e32. I should probably already have asked here, but can you elaborate on this? What do you mean? What is missing? We can reintroduce this statement or a similar one. Currently it's not clear and I also don't fully understand it.
Co-authored-by: Frédéric Simonis <[email protected]>
|
See #118. Systemtest is currently not working due to an issue in the systemtests repository. |
This was referenced Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting FEniCS as install requirement may break the installation (see #103). We therefore check whether FEniCS is installed and abort, if this is not the case.
Closes #103.
@fsimonis @IshaanDesai What do you think about this approach?