Skip to content

Commit

Permalink
docs: fix mlx feature in "multiple machines" example
Browse files Browse the repository at this point in the history
The example as it was would not solve, it ends with a fairly
obscure error:

```
  × failed to solve the conda requirements of 'mlx' 'osx-arm64'
  ╰─▶ Cannot solve the request because of: mlx >=0.5.0,<0.6.0 cannot be installed because there are no viable options:
      └─ mlx 0.5.0 | 0.5.0 | 0.5.0 | 0.5.0 | 0.5.0 | 0.5.1 | 0.5.1 | 0.5.1 | 0.5.1 | 0.5.1 would require
         └─ __osx >=13.3, for which no candidates were found.
```

This was already found previously in
#562 (comment),
and the fix is to add a minimum macOS version.
Note that the conda-forge package metadata (saying >=13.3) is also incorrect,
the 13.5 minimum added to the example comes from the MLX docs:
https://ml-explore.github.io/mlx/build/html/install.html#

While we're at it, also update to a recent MLX version.
  • Loading branch information
rgommers committed Aug 8, 2024
1 parent 8b102b3 commit 094ba23
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion docs/features/multi_environment.md
Original file line number Diff line number Diff line change
Expand Up @@ -443,13 +443,15 @@ Dev
[feature.mlx]
platforms = ["osx-arm64"]
# MLX is only available on macOS >=13.5 (>14.0 is recommended)
system-requirements = {macos = "13.5"}
[feature.mlx.tasks]
train-model = "python train.py --mlx"
evaluate-model = "python test.py --mlx"
[feature.mlx.dependencies]
mlx = ">=0.5.0,<0.6.0"
mlx = ">=0.16.0,<0.17.0"
[feature.cpu]
platforms = ["win-64", "linux-64", "osx-64", "osx-arm64"]
Expand Down

0 comments on commit 094ba23

Please sign in to comment.