Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor PyPiRequirement to use serde_untagged #621

Closed
baszalmstra opened this issue Jan 6, 2024 · 1 comment · Fixed by #744
Closed

refactor PyPiRequirement to use serde_untagged #621

baszalmstra opened this issue Jan 6, 2024 · 1 comment · Fixed by #744
Labels
🔃 refactor Specifies PR or Issue is related to a refactor 👋 good first issue Good for newcomers

Comments

@baszalmstra
Copy link
Contributor

I stumbled upon serde_untagged and I think it would be very useful to remove some of the complexity of the Deserialize impl for PyPiRequirement. See:

impl<'de> Deserialize<'de> for PyPiRequirement {

Might be a nice "first issue".

@baszalmstra baszalmstra added 👋 good first issue Good for newcomers 🔃 refactor Specifies PR or Issue is related to a refactor labels Jan 6, 2024
@marcelotrevisani
Copy link
Contributor

I am not sure if this is what you meant, but I am happy to give it a go
#622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔃 refactor Specifies PR or Issue is related to a refactor 👋 good first issue Good for newcomers
Projects
None yet
2 participants