Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell command #116

Merged
merged 31 commits into from
Jun 23, 2023
Merged

Conversation

ruben-arts
Copy link
Contributor

Adding the ability to run pixi shell next to pixi run x so people can activate the environment and run there commands in there.

@wolfv
Copy link
Member

wolfv commented Jun 20, 2023

A good way to support more shells properly is to first run bash and then the target shell. That way all the activation scripts usually work.

E.g. bash -c "./activation.sh && exec $TARGET_SHELL where $TARGET_SHELL could be fish or xonsh...

@baszalmstra
Copy link
Contributor

I think when using powershell this is very important! Not all packages support powershell.

@baszalmstra
Copy link
Contributor

I get this error:

E:\Developer\prefix\pixi\myproject>$SHELL
'$SHELL' is not recognized as an internal or external command,
operable program or batch file.

@ruben-arts ruben-arts mentioned this pull request Jun 22, 2023
@ruben-arts ruben-arts marked this pull request as ready for review June 23, 2023 11:40
@baszalmstra
Copy link
Contributor

@ruben-arts and I just tested this one windows. It selected the proper shell both in powershell.exe, pwsh.exe and cmd.exe.

@ruben-arts ruben-arts merged commit d595b98 into prefix-dev:main Jun 23, 2023
@ruben-arts ruben-arts deleted the feature/add_shell_command branch June 23, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants