Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: channel priority logic #1332

Merged
merged 3 commits into from
May 6, 2024

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented May 6, 2024

The issue described in #1331 can be simplified into the added test:

[project]
name = "holoviews"
channels = ["a", "b"]
platforms = ["linux-64"]

[environments]
foo = ["foo"]

[feature.foo]
channels = ["a", "c", "b"]

The channels for env foo should be ["a", "c", "b"] but the current logic in v0.21.0 changes it to have the default feature channels always at the end resulting in ["c", "a', "b"].

We changed this back to keep the order of the features, and only add the missing channels from default last in the list.

So this fixes #1331

@ruben-arts ruben-arts changed the title Fix channel priority logic fix: channel priority logic May 6, 2024
@ruben-arts ruben-arts marked this pull request as draft May 6, 2024 19:26
@ruben-arts ruben-arts marked this pull request as ready for review May 6, 2024 20:02
@wolfv wolfv merged commit 5c4cfdf into prefix-dev:main May 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwriting channels in features broken in v0.21.0
3 participants