Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: canonicalize path before parsing it as path. #155

Merged
merged 4 commits into from
Jun 29, 2023
Merged

fix: canonicalize path before parsing it as path. #155

merged 4 commits into from
Jun 29, 2023

Conversation

ruben-arts
Copy link
Contributor

fix #154

@baszalmstra
Copy link
Contributor

For canonicalize to work, the path must exist. So this won't work anymore:

pixi init randompath

@baszalmstra
Copy link
Contributor

baszalmstra commented Jun 29, 2023 •
edited
Loading

You probably want to check if path is relative and only then join it with the current directory.

@baszalmstra
Copy link
Contributor

With #140 now merged it would also be good to add a test for this!

@wolfv wolfv merged commit 49630ec into prefix-dev:main Jun 29, 2023
@ruben-arts ruben-arts deleted the fix/init_dir_name branch February 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfv wolfv wolfv approved these changes

@tdejager tdejager Awaiting requested review from tdejager

@baszalmstra baszalmstra Awaiting requested review from baszalmstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thread 'main' panicked at 'called Option::unwrap() on a None value' error on pixi init . on Windows
3 participants
@ruben-arts @baszalmstra @wolfv