Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve spec parsing error messages #1786

Merged

Conversation

baszalmstra
Copy link
Contributor

@baszalmstra baszalmstra commented Aug 11, 2024

Improves error handling of specs that look like matchspecs. The error handler tries to parse the input string as a matchspec and outputs a nice error message that should how it should be added as a detailed spec.

E.g. the following from #1782:

jaxlib = "*cpu*"

now results in:

expected a version specifier but looks like a matchspec, did you mean { version = "*", build = "cpu*" }?

The following from #1785:

libblas = "*=*openblas"

results in:

expected a version specifier but looks like a matchspec, did you mean { version = "*", build = "*openblas" }?

There are still some weird edge cases when specifying a channel inline, as can be seen in the tests. This will be fixed with conda/rattler#810

@ruben-arts ruben-arts merged commit b21f3ae into prefix-dev:main Aug 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants