Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 1797 #1851

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: issue 1797 #1851

merged 2 commits into from
Aug 20, 2024

Conversation

baszalmstra
Copy link
Contributor

This PR contains two changes.

  • When converting from a pyproject manifest to an internal manifest, errors can occur, these are now handled properly.
  • I changed add_pypi_dependency to add_pep508_dependency when the function accepts a pep508 requirement.
  • Parsing of git urls with @ works properly now but might still fail if not pointing to a revision (but a branch instead). The error message does now reflect this shortcoming.

Fixes #1797 as the code no longer panics but does still result in an error.

@ruben-arts ruben-arts enabled auto-merge (squash) August 20, 2024 15:04
@ruben-arts ruben-arts merged commit 21a8c6a into prefix-dev:main Aug 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixi panics on parsing a git+ssh url in pyproject.toml dependencies
2 participants