Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable use of manylinux wheeltags once again #1925

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

tdejager
Copy link
Contributor

This boolean was filtering out the creation of manylinux wheel tags.

@tdejager tdejager changed the title fix: enable use of manylnux wheeltags once again fix: enable use of manylinux wheeltags once again Aug 27, 2024
@wolfv
Copy link
Member

wolfv commented Aug 27, 2024

Can we test this in some way to prevent regressions? Maybe with Rubens new integration tests?

@tdejager
Copy link
Contributor Author

tdejager commented Aug 27, 2024

Sure we could test more, but this only adds more tags not less :)

Edit: or do you mean so that this particular kind of regression does not happen again? In that case sure, but lets do that in a different PR.

@liblaf
Copy link

liblaf commented Aug 27, 2024

I tested the installation of some PyPI packages on this PR. Here's the result:

Results
Package pip pixi uv
confz
dvc
dvclive
icecream
jax
jax[cuda12]
matplotlib
meshio[all]
meshpy
meshtaichi-patcher
mkdocs
mkdocs-material
mkdocstrings[python]
numpy
pymeshfix
pyright
pytest
pytest-benchmark
pyvista
ruff
scipy
sparse
taichi
trimesh[all]
typeguard

sparse still cannot be managed. There may be an upstream issue with uv.

@wolfv
Copy link
Member

wolfv commented Aug 27, 2024

Yes, i think adding some pypi dep to a end-to-end test that uses these tags would be nice

@tdejager
Copy link
Contributor Author

Thank you @liblaf!

@tdejager
Copy link
Contributor Author

Yes, i think adding some pypi dep to a end-to-end test that uses these tags would be nice

Added a single test, that should at least catch if we disable that boolean again :)

@ruben-arts ruben-arts merged commit 39c4377 into prefix-dev:main Aug 28, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants