-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable use of manylinux wheeltags once again #1925
fix: enable use of manylinux wheeltags once again #1925
Conversation
Can we test this in some way to prevent regressions? Maybe with Rubens new integration tests? |
Sure we could test more, but this only adds more tags not less :) Edit: or do you mean so that this particular kind of regression does not happen again? In that case sure, but lets do that in a different PR. |
I tested the installation of some PyPI packages on this PR. Here's the result: Results
sparse still cannot be managed. There may be an upstream issue with uv. |
Yes, i think adding some pypi dep to a end-to-end test that uses these tags would be nice |
Thank you @liblaf! |
Added a single test, that should at least catch if we disable that boolean again :) |
This boolean was filtering out the creation of manylinux wheel tags.