fix: --import env_file potentially breaks channel priority #2113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation updates the
extra_channels
read fromdependencies
using the channels read fromenvfile
, which introduces an unnecessary assumption that the entries independencies
need to be arranged in the expected order of priority.This may not happen in many cases. Generally speaking, channels in the
env_file
can be considered sorted, whiledependencies
are unordered. Additionally, if new channels appear inextra_channels
, placing them at the end of the priority list should be a safer default behavior.Consider the following example from https://pixi.sh/dev/advanced/channel_priority/#use-case-pytorch-and-nvidia-with-conda-forge, which generates an incorrect
pixi.toml
:pixi init --import
will result in