Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grouping for exposing and removing #2387

Merged

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Oct 30, 2024

new output:
Screenshot 2024-10-30 at 15 31 57
Screenshot 2024-10-30 at 15 34 04

@nichmor nichmor marked this pull request as ready for review October 30, 2024 14:46
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, great job!

I only had one comment.
After CI is green, we can merge this 🚀

src/global/project/manifest.rs Outdated Show resolved Hide resolved
@nichmor
Copy link
Contributor Author

nichmor commented Oct 31, 2024

Works as expected, great job!

I only had one comment. After CI is green, we can merge this 🚀

fixed the test. should be green now

@Hofer-Julian
Copy link
Contributor

Works as expected, great job!
I only had one comment. After CI is green, we can merge this 🚀

fixed the test. should be green now

There's still a lint error :)

@nichmor
Copy link
Contributor Author

nichmor commented Oct 31, 2024

Works as expected, great job!
I only had one comment. After CI is green, we can merge this 🚀

fixed the test. should be green now

There's still a lint error :)

oh my bad - should be good now 🤞

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@ruben-arts
Copy link
Contributor

❯ pixi g install python=3.11 -e p
Global environments as specified in '/home/rarts/.pixi/manifests/pixi-global.toml'
└── p (installed)
    ├─ dependencies: python 3.11.10
    └─ exposes: 2to3, 2to3-3.11, idle3, idle3.11, pydoc, pydoc3, pydoc3.11, python, python3, python3-config, python3.1, python3.11, python3.11-config

❯ pixi g add matplotlib -e p
✔ Updated package matplotlib 3.9.2 in environment p.
✔ Updated executable 2to3 of environment p.
✔ Updated executable python3 of environment p.
✔ Updated executable python3.11 of environment p.
✔ Updated executable python3.11-config of environment p.
✔ Updated executable python3-config of environment p.
✔ Updated executable pydoc of environment p.
✔ Updated executable pydoc3 of environment p.
✔ Updated executable pydoc3.11 of environment p.
✔ Updated executable idle3.11 of environment p.
✔ Updated executable python of environment p.
✔ Updated executable python3.1 of environment p.
✔ Updated executable idle3 of environment p.
✔ Updated executable 2to3-3.11 of environment p.
✔ Added package matplotlib=3.9.2 to environment p.

❯ pixi g rm python -e p
✔ Updated package python 3.11.10 -> 3.12.7 in environment p.
✔ Removed exposed executables from environment p:
   - 2to3
   - 2to3-3.11
   - idle3
   - idle3.11
   - pydoc
   - pydoc3
   - pydoc3.11
   - python
   - python3
   - python3-config
   - python3.1
   - python3.11
   - python3.11-config

I think Updated should get the same output. Also I think there is a bug in the update exe logic but this is not added in this PR. As It should not have told me it updated those executables in this case.

@ruben-arts
Copy link
Contributor

Thanks the updated works now to!

@ruben-arts ruben-arts enabled auto-merge (squash) November 1, 2024 08:45
@ruben-arts ruben-arts merged commit 24e4def into prefix-dev:main Nov 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants