Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reorganize integration tests #2408

Merged
merged 8 commits into from
Nov 5, 2024
Merged

test: reorganize integration tests #2408

merged 8 commits into from
Nov 5, 2024

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian
Copy link
Contributor Author

Hofer-Julian commented Nov 4, 2024 •
edited
Loading

Procedure to test speed-up:

  • run pixi run test
  • change any comment in src/prefix.rs
  • run pixi run test (<- measure this)

On my machine on main: 20 sec
On my machine with this PR: 10 sec

@Hofer-Julian Hofer-Julian marked this pull request as ready for review November 4, 2024 15:48
@baszalmstra
Copy link
Contributor

On main: 27sec 764ms 487µs 500ns
On this PR: 14sec 977ms 917µs 200ns

@Hofer-Julian Hofer-Julian enabled auto-merge (squash) November 5, 2024 13:17
@Hofer-Julian Hofer-Julian merged commit 1ee9605 into prefix-dev:main Nov 5, 2024
21 checks passed
@Hofer-Julian Hofer-Julian deleted the test/integration-refactor branch November 5, 2024 13:23
@BrewTestBot BrewTestBot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-arts ruben-arts ruben-arts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hofer-Julian @baszalmstra @ruben-arts