Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: channel add command #254

Closed
wants to merge 2 commits into from

Conversation

baszalmstra
Copy link
Contributor

Adds the pixi channel add command to add channels to a project and regenerate the lock-file in one go.

@wolfv
Copy link
Member

wolfv commented Aug 11, 2023

We could also consider a "project add channel xxx" and "project add platform xxx" subcommand

@baszalmstra
Copy link
Contributor Author

I had a discussion about this @ruben-arts as well. I see pixi channel add as an analog to git remote add. Why do you prefer to add an additional subcommand (e.g. project)?

@wolfv
Copy link
Member

wolfv commented Aug 12, 2023

I was mainly thinking about not cluttering the global subcommands too much. Also it would match well with some other project settings like subdirs/platforms.
But I also get your argument

@ruben-arts
Copy link
Contributor

I have to say I cant remember the last conversation we had about this but what if we do the pixi project channel add xxx and then open a "good first issue" for contributors to extend the functionality with the rest of the project info?

Because I think this feature is also nice for the platforms and the version for instance. But adding a pixi platform add and a pixi version add seems to clutter the main cli to me.

@baszalmstra
Copy link
Contributor Author

Yes correct! We decided to put them under the project subcommand.

baszalmstra pushed a commit that referenced this pull request Sep 20, 2023
Added the #254 but with the `project` prefix. So the main cli entry
point stays as clean as possible. This is beneficial for future
expansion.
@ruben-arts
Copy link
Contributor

ruben-arts commented Sep 21, 2023

Can be closed as it was moved to a project subcommand in #347 .

@ruben-arts ruben-arts closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants