Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sdists in pixi #664

Merged
merged 11 commits into from
Jan 18, 2024
Merged

Conversation

tdejager
Copy link
Contributor

@tdejager tdejager commented Jan 12, 2024

Finally, the PR that adds sdist support for pixi. This is still in draft until I add some tests for it, I had a previous branch where I did this, so will need to move these back. Will get to this on monday.

For now you can try, pixd is my alias for a local build of pixi:

pixd init .
pixd add python
pixd --pypyi helium #helium is source only release

This works on my machine 🤞 sdist should also work, in the test I will make it so you can explicitely enable only sdists but I do not want this user-facing.

Give it a go!

Fixes: #628

still need to write some more tests
@wolfv
Copy link
Member

wolfv commented Jan 13, 2024

Worked! Nice :)

Copy link
Member

@wolfv wolfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff :)

examples/pypi/helium_test.py Outdated Show resolved Hide resolved
tests/common/mod.rs Show resolved Hide resolved
@tdejager tdejager marked this pull request as ready for review January 15, 2024 13:14
src/environment.rs Outdated Show resolved Hide resolved
examples/pypi/helium_test.py Outdated Show resolved Hide resolved
@ruben-arts
Copy link
Contributor

ruben-arts commented Jan 18, 2024

Before merging, I found that it never satisfies the lock. I'll investigate now.

Edit:
Issue is:

INFO pixi::lock_file::satisfiability: failed to find a locked package for 'urllib3[socks] >=1.26, <3', assuming the lock file is out of date.

Edit2:
Urllib3 seems to include the socks but I think there is no way to check for the [socks] part? (just guessing at this point)
Maybe because it sees it uses the conda package.

- platform: win-64
  name: urllib3
  version: 2.1.0
  category: main
  manager: conda
  dependencies:
  - brotli-python >=1.0.9
  - pysocks >=1.5.6,<2.0,!=1.5.7
  - python >=3.7
  url: https://conda.anaconda.org/conda-forge/noarch/urllib3-2.1.0-pyhd8ed1ab_0.conda
  hash:
    md5: f8ced8ee63830dec7ecc1be048d1470a
    sha256: eff5029820b4eaeab3a291a39854a6cd8fc8c4216264087f68c2d8d59822c869
  build: pyhd8ed1ab_0
  arch: x86_64
  subdir: win-64
  build_number: 0
  license: MIT
  license_family: MIT
  noarch: python
  size: 85324
  timestamp: 1699933655057
  purls:
  - pkg:pypi/urllib3

Note

This was already here before the sdist
Repro: pixi add --pypi selenium && pixi i

@tdejager
Copy link
Contributor Author

Small test error after adding bail gonna change the pixi API a bit.

@tdejager tdejager merged commit bd4e26d into prefix-dev:main Jan 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass the current pixi python interpeter to RIP for wheel building
3 participants