Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add to feature #803

Merged
merged 10 commits into from
Feb 23, 2024
Merged

feat: add to feature #803

merged 10 commits into from
Feb 23, 2024

Conversation

ruben-arts
Copy link
Contributor

Adds

pixi add -f/--feature featurex numpy

Code paths:

  • Get best version of all environments that use this feature. And min max on the set of versions of all environments combined.
  • Get latest version if feature is not added to any environment.
  • Get any version ("*") if it fails to fetch any of the other info.

baszalmstra
baszalmstra reviewed Feb 13, 2024
View reviewed changes
src/cli/add.rs Show resolved Hide resolved
src/cli/add.rs Outdated Show resolved Hide resolved
src/environment.rs Outdated Show resolved Hide resolved
src/project/manifest/mod.rs Outdated Show resolved Hide resolved
src/project/mod.rs Show resolved Hide resolved
@baszalmstra baszalmstra mentioned this pull request Feb 13, 2024
Closed
@ruben-arts ruben-arts changed the title Feature/add to feature feature: add to feature Feb 22, 2024
@ruben-arts ruben-arts changed the title feature: add to feature feat: add to feature Feb 22, 2024
baszalmstra
baszalmstra reviewed Feb 23, 2024
View reviewed changes
src/project/grouped_environment.rs Outdated Show resolved Hide resolved
src/project/mod.rs Outdated Show resolved Hide resolved
@ruben-arts ruben-arts merged commit 5348a25 into prefix-dev:main Feb 23, 2024
17 checks passed
@ruben-arts ruben-arts deleted the feature/add_to_feature branch February 23, 2024 15:44
@sumanth-manchala sumanth-manchala mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Multiple environment support in `pixi`
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruben-arts @baszalmstra