Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check duplicates while adding dependencies #829

Merged
merged 5 commits into from
Feb 23, 2024
Merged

fix: check duplicates while adding dependencies #829

merged 5 commits into from
Feb 23, 2024

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Feb 22, 2024

closes #825

ruben-arts
ruben-arts reviewed Feb 22, 2024
View reviewed changes
src/cli/add.rs Outdated Show resolved Hide resolved
@ruben-arts
Copy link
Contributor

It think it is fine if we don't allow pixi add to add capitalization.

Btw, it doesn't work yet. Im testing with:

pixi add flask
pixi add Flask # this should already fail
pixi install # but it fails here

@orhun orhun changed the title fix: check duplicates while adding dependencies fix: disallow mixed case dependency names Feb 22, 2024
@orhun orhun changed the title fix: disallow mixed case dependency names fix: check duplicates while adding dependencies Feb 22, 2024
@ruben-arts ruben-arts merged commit dc4289e into prefix-dev:main Feb 23, 2024
15 checks passed
@sumanth-manchala sumanth-manchala mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-arts ruben-arts ruben-arts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't leave pixi.toml in broken state
2 participants
@orhun @ruben-arts