-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: install Windows executable when executing install.sh
in Git Bash
#966
Conversation
Hmm, when you are on Windows, you should download the Windows binary. Or do I misunderstand something? |
The chmod stuff can likely be skipped on Windows. |
Doh. Good point. I was the one misunderstanding something. Now I understand how this can work. I'll test and push an update |
install.sh
in Git Bash
Ok, now I've got it working in Git Bash bash install/install.sh
## This script will automatically download and install Pixi (latest) for you.
## Getting it from this url: https://github.com/prefix-dev/pixi/releases/latest/download/pixi-x86_64-pc-windows-msvc.zip
## ################################################################################################################ 100.0%
## Archive: /tmp/.pixi_install.uZMw2jaz
## inflating: /c/Users/john/.pixi/bin/pixi.exe
## The 'pixi' binary is installed into '/c/Users/john/.pixi/bin'
## Updating '/c/Users/john/.bash_profile'
## Please restart or source your shell.
# in a new shell
pixi --version
## pixi 0.16.1
ls -l ~/.pixi/bin/
## total 26624
## -rwxr-xr-x 1 john 197121 27260928 Mar 11 13:21 pixi.exe* |
Cool! Then we just need to fix |
I also confirmed that my updates to support Git Bash did not break a standard installation in Ubuntu: bash install/install.sh
## This script will automatically download and install Pixi (latest) for you.
## Getting it from this url: https://github.com/prefix-dev/pixi/releases/latest/download/pixi-x86_64-unknown-linux-musl.tar.gz
## ####################################################################################################### 100.0%
## The 'pixi' binary is installed into '/home/wsl/.pixi/bin'
## Updating '/home/wsl/.bashrc'
## Please restart or source your shell.
# In a new shell
pixi --version
## pixi 0.16.1 |
CI is green. Ready for review. Please let me know if you'd like me to rebase onto main |
Looks good, one small comment |
8d4383b
to
793ea44
Compare
Thank you @jdblischak and @wolfv, this is much appreciated. I left a comment here that might offer a solution to the |
Closes #965
This PR downloads and installs
pixi
in a Git Bash shell on Windows. I've updatedinstall.sh
to properly download theLinuxWindows executable.However, the commandchmod +x "$BIN_DIR/pixi"
doesn't work on Windows, so I can't runpixi
after downloading it. Any ideas?